1488401 - Remove the remnants of the DiskSpaceWatcher

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), enhancement)

Description

[Gabriele Svelto [:gsvelto]]

The DiskSpaceWatcher was only ever implemented on B2G/Firefox OS and the Gonk implementation was removed a year and a half ago. Since no other implementation has been requested and the relevant code is essentially untested since the cancellation of the Firefox OS project we should remove all the related code.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1488401 - Remove the remnants of the DiskSpaceWatcher

Comment 2

[Marco Castelluccio [:marco]]

I had noticed this in https://marco-c.github.io/code-coverage-reports/#toolkit/components/diskspacewatcher, but forgot to file a bug.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 9006234 [details]
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher

Andrew Sutherland [:asuth] has approved the revision.

Comment 4

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Comment on attachment 9006234 [details]
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher

Olli Pettay [:smaug] has approved the revision.

Comment 5

[Gabriele Svelto [:gsvelto]]

I almost forgot, here's the try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f69d88bcd75e1041fb95f1539797ca5df7b3dbe9

Comment 6

[Jan Varga [:janv]]

Let me test this with new local storage implementation ...

Comment 7

[Jan Varga [:janv]]

Comment on attachment 9006234 [details]
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher

Jan Varga [:janv] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3206c9b8db97
Remove the remnants of the DiskSpaceWatcher r=asuth,janv,smaug

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3206c9b8db97