1488403 - Make sticky legend reftest not rely on groove border antialising.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Emilio Cobos Álvarez [:emilio]]

This is failing with my patch to fix groove borders because of a slight antialising difference:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e3afa2058fd3f1ed19af3a2fd9eec0e9e817704

I'll explain in the commit message why I think we shouldn't worry about it.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Make sticky legend reftest not depend on groove border antialising.

This reftest fails with my changes from
https://github.com/servo/webrender/pull/3010. I tried to debug locally but it
passes here.

The reason it fails is because WebRender does distance AA between the segments
of a ridge / groove border, and there's a subpixel difference so we get the AA
slightly different in the test.

Gecko on the other hand represents these borders as different composed solid
segments, so it can't have this problem, since it doesn't do AA across the
segments.

We may want to change that, but it's not clear to me it's wanted, since rounded
corners for these look much better on WR, for example.

Rather than fuzzing the test or something like that, make the test not rely on
that, given it's testing the position of the legend.

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 9006235 [details]
Make sticky legend reftest not depend on groove border antialising.

Nicolas Silva [:nical] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4f3b85bc61b
Make sticky legend reftest not depend on groove border antialising. r=nical

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e4f3b85bc61b