Change the ESLint configuration to default to eslint:recommended and clean up old configs

RESOLVED FIXED in Firefox 64

Status

P2
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla64

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 months ago
Per bug 1487642 I think we should switch to basing our configuration on eslint:recommended. It helps us get more of the common rules enabled, and simplifies things a little.

Additionally, there's quite a few deprecated or removed rules for ESLint that have been removed from the tree, so we should drop those as well.
(Assignee)

Comment 1

5 months ago
Created attachment 9006279 [details]
Bug 1488445 - Change the ESLint configuration to extend from eslint:recommended.

This enables the following extra rules over the current configuration:

- for-direction
- no-compare-neg-zero
- no-new-symbol
- no-this-before-super

Other rules that are in eslint:recommended but not in our configuration are turned off for now.
(Assignee)

Comment 2

5 months ago
Created attachment 9006281 [details]
Bug 1488445 - Remove and replace obsolete ESLint rules.

This removes a number of references to rules that are now deprecated or removed from ESLint.

- no-native-reassign is replaced with no-global-assign
- no-spaced-func is replaced with func-call-spacing (where enabled)

Depends on D4944
Comment on attachment 9006279 [details]
Bug 1488445 - Change the ESLint configuration to extend from eslint:recommended.

Dave Townsend [:mossop] (he/him) has approved the revision.
Attachment #9006279 - Flags: review+
Comment on attachment 9006281 [details]
Bug 1488445 - Remove and replace obsolete ESLint rules.

Dave Townsend [:mossop] (he/him) has approved the revision.
Attachment #9006281 - Flags: review+

Comment 5

5 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e1a263dd83d
Change the ESLint configuration to extend from eslint:recommended. r=mossop

Comment 6

5 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1780997e89ef
Remove and replace obsolete ESLint rules. r=mossop
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12833 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
https://hg.mozilla.org/mozilla-central/rev/8e1a263dd83d
https://hg.mozilla.org/mozilla-central/rev/1780997e89ef
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.