1488445 - Change the ESLint configuration to default to eslint:recommended and clean up old configs

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, enhancement, P2)

Description

[Mark Banner (:standard8)]

Per bug 1487642 I think we should switch to basing our configuration on eslint:recommended. It helps us get more of the common rules enabled, and simplifies things a little.

Additionally, there's quite a few deprecated or removed rules for ESLint that have been removed from the tree, so we should drop those as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1488445 - Change the ESLint configuration to extend from eslint:recommended.

This enables the following extra rules over the current configuration:

- for-direction
- no-compare-neg-zero
- no-new-symbol
- no-this-before-super

Other rules that are in eslint:recommended but not in our configuration are turned off for now.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1488445 - Remove and replace obsolete ESLint rules.

This removes a number of references to rules that are now deprecated or removed from ESLint.

- no-native-reassign is replaced with no-global-assign
- no-spaced-func is replaced with func-call-spacing (where enabled)

Depends on D4944

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 9006279 [details]
Bug 1488445 - Change the ESLint configuration to extend from eslint:recommended.

Dave Townsend [:mossop] (he/him) has approved the revision.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 9006281 [details]
Bug 1488445 - Remove and replace obsolete ESLint rules.

Dave Townsend [:mossop] (he/him) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e1a263dd83d
Change the ESLint configuration to extend from eslint:recommended. r=mossop

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1780997e89ef
Remove and replace obsolete ESLint rules. r=mossop

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12833 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 10

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8e1a263dd83d
https://hg.mozilla.org/mozilla-central/rev/1780997e89ef