Closed Bug 1488448 Opened Last year Closed Last year

Switch blacklist check to ignore case

Categories

(Firefox :: Search, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

blacklist check should ignore case so it can't be worked around that way.
Priority: -- → P1
Comment on attachment 9006292 [details]
Bug 1488448 - Ignore case on blacklist check.

Drew Willcoxon :adw has approved the revision.
Attachment #9006292 - Flags: review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/5020b4bda0ef
Ignore case on blacklist check. r=adw
https://hg.mozilla.org/mozilla-central/rev/5020b4bda0ef
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Is this something that needs Beta uplift consideration?
Flags: needinfo?(mozilla)
Comment on attachment 9006292 [details]
Bug 1488448 - Ignore case on blacklist check.

Approval Request Comment
[Feature/Bug causing the regression]: Make blacklist search check  more robust.
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No, covered by automated.
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Change to existing string handling, automated test.
[String changes made/needed]: none
Flags: needinfo?(mozilla)
Attachment #9006292 - Flags: approval-mozilla-beta?
Comment on attachment 9006292 [details]
Bug 1488448 - Ignore case on blacklist check.

Uplift approved for 63 beta 5.
Attachment #9006292 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.