1488448 - Switch blacklist check to ignore case

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Mike Kaply [:mkaply]]

blacklist check should ignore case so it can't be worked around that way.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1488448 - Ignore case on blacklist check.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 9006292 [details]
Bug 1488448 - Ignore case on blacklist check.

Drew Willcoxon :adw has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5020b4bda0ef
Ignore case on blacklist check. r=adw

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5020b4bda0ef

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something that needs Beta uplift consideration?

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 9006292 [details]
Bug 1488448 - Ignore case on blacklist check.

Approval Request Comment
[Feature/Bug causing the regression]: Make blacklist search check  more robust.
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No, covered by automated.
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Change to existing string handling, automated test.
[String changes made/needed]: none

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9006292 [details]
Bug 1488448 - Ignore case on blacklist check.

Uplift approved for 63 beta 5.

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7b56a5ad6f1f