Closed Bug 1488449 Opened 6 years ago Closed 6 years ago

[screenshot] Big pages can't be screenshotted, fails without a message

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 766661

People

(Reporter: julienw, Unassigned)

Details

STR: 1. enable the screenshot toolbox button in Firefox Devtools 2. go to https://phabricator.services.mozilla.com/D3618?large=true 3. Try to screenshot the page using the button => nothing happens. Except that when you're scrolled down, the page is scrolled up to the top. This doesn't happen on smaller pages.
stack strace: createScreenshotDataURL@resource://devtools/shared/base-loader.js -> resource://devtools/shared/screenshot/capture.js:93:3 captureScreenshot@resource://devtools/shared/base-loader.js -> resource://devtools/shared/screenshot/capture.js:41:10 capture@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/screenshot.js:18:12 handler@resource://devtools/shared/base-loader.js -> resource://devtools/shared/protocol.js:1178:21 onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1711:15 receiveMessage@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/child-transport.js:66:5 MessageListener.receiveMessage*_addListener@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/child-transport.js:40:5 ready@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/child-transport.js:57:5 _onConnection@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1146:5 connectToParent@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:577:12 onConnect</<@resource://devtools/server/startup/frame.js:50:22 onConnect<@resource://devtools/server/startup/frame.js:49:7 exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14 MessageListener.receiveMessage*@resource://devtools/server/startup/frame.js:72:5 @resource://devtools/server/startup/frame.js:19:4 most likely too large 2d canvas
Sorry Julien, it's a dupe :-/
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Isn't it possible to show something to the user when we get the error ? Some friendly error message in the webconsole ? Or is it too async so that it's difficult to do ?
I agree that can be the right thing to do for now, I believe it shouldn't be that async.
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.