1488467 - Support adding and removing languages from the requested list

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Mark Striemer [:mstriemer]]

In the language alternatives dialog a user should be able to move installed languages between the requested and available lists.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1488467 - Part 1: Support adding and removing installed browser languages r?jaws,zbraniecki

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: add-remove-browser-languages.mov

Here's a video of how it works. Disabled language packs are still ignored.

I also just noticed it still needs some minor CSS tweaks, I'll update the patch tonight/tomorrow with that.

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1488467 - Part 2: Match web languages dialog with browser dialog r?jaws

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: web-languages-dialog.png

CSS is updated, here are some new screenshots.

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: browser-languages-dialog.png

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

A small source of confusion that I observed so far in the conversation about this UI is about handling edge cases where a locale is added, but doesn't work, or gets disabled, or becomes unavailable for another reason.

I think the source of confusion comes from the difference between adding/ordering/removing *language packs* vs. adding/ordering/removing *requested locales*.

The difference feels subtle, and I completely understand why we want to avoid forcing such detail onto the user, but unfortunately pretending that they're directly operating on existing locales rather than requested has its consequences exactly when such edge cases happen.

I consulted the MacOS UI for language selection and noticed that they use the vocabulary about "preferred locales". It doesn't seem random. It seems like they try to communicate to the user, in a gentle way, that what the user is operating on is their preference, not the result of that preference against available resources.

I'm wondering if maybe we could try to fine-tune wording/UX to better reflect that reality and avoid people reporting that "I added X and it doesn't work". Because it sometimes won't. So if the narrative is "I requested X and it doesn't work", and that matches the reality better.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9006398 [details]
Bug 1488467 - Part 1: Support adding and removing installed browser languages r?jaws,zbraniecki

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9006581 [details]
Bug 1488467 - Part 2: Match web languages dialog with browser dialog r?jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3ef1330cf04
Part 1: Support adding and removing installed browser languages r=jaws
https://hg.mozilla.org/integration/autoland/rev/97384d72b069
Part 2: Match web languages dialog with browser dialog r=jaws

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d3ef1330cf04
https://hg.mozilla.org/mozilla-central/rev/97384d72b069

Comment 11

[Mark Striemer [:mstriemer]]

Comment on attachment 9006581 [details]
Bug 1488467 - Part 2: Match web languages dialog with browser dialog r?jaws

We'd like to test the multilingual interface in Beta/Release 63 before enabling in 64 since it has parts that don't work in Nightly. This will be required for future patches to land.

Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Behind a disabled pref
[String changes made/needed]: None

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9006581 [details]
Bug 1488467 - Part 2: Match web languages dialog with browser dialog r?jaws

Low risk for 63 as this is behind a pref,  uplift approved for 63 beta 7.

Mark, I am supposing that you meant to uplift both part 1 and 2 of the patch, not just part 2 on which you requested the uplift, can you confirm please? Thanks.

Comment 13

[Mark Striemer [:mstriemer]]

Yes, both parts, please!

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6224d9ad89ba
https://hg.mozilla.org/releases/mozilla-beta/rev/221d11dbdbb6

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

(In reply to Mark Striemer [:mstriemer] from comment #11)
> [Is this code covered by automated tests?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Marking this as qe-verify- per Mark's assessment on manual testing needs and its automated coverage.