1488508 - Update help icon to photon styling.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Help Icon used in debugger.html, about:debugging, netmonitor and accessibility panel is not up to date with photon styling.

This one should be used instead: https://design.firefox.com/icons/icons/android/help-24.svg

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1488508 - update help icon to use Photon style system. r=gl

MozReview-Commit-ID: 75efDzRq187

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9006310 [details]
Bug 1488508 - update help icon to use Photon style system. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5de35217ebf9
update help icon to use Photon style system. r=gl

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5de35217ebf9

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9006310 [details]
Bug 1488508 - update help icon to use Photon style system. r=gl

[Feature/Bug causing the regression]: Not a regression, visual polish
[User impact if declined]: Devtools users will see an old (non-Photon styled) icon in places where help icon is used (debugger.html, accessibility inspector, netmonitor, about:debugging).
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Mp
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Minor CSS change
[String changes made/needed]: None

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9006310 [details]
Bug 1488508 - update help icon to use Photon style system. r=gl

Minor polish I verified in Nightly, accepting uplift for 63 beta 4

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed22d4ac3465

Comment 8

[Cristian Craciun]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180906162647

Verified as fixed on the latest Beta version (63.0b4).

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Debugger.html updated styles. Needs to be fixed in m-c and upstream.

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Apologies, something on my local machine was not up to date, everything seems to be fixed indeed.