Ship |clip-path:path()|
Categories
(Core :: Layout, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete, parity-safari)
Attachments
(2 files)
We add a pref for |clip-path:path()| and it is default off in Bug 1487838. After we decide to ship it, let's remove the pref in this bug.
|
||
Comment 1•5 years ago
|
||
FWIW, it seems to me that Safari has already shipped this (as opposed to what's stated in MDN page). Chrome doesn't seem to have supported it, though.
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
There are currently no blocking bugs referenced. So, what's holding this from being shipped?
Sebastian
|
|
||
Comment 3•5 years ago
|
||
Btw, I've updated the information about this function on the "Experimental features for Firefox" MDN page.
And I've added the dev-doc-needed keyword now, so it will be documented once it gets shipped.
Sebastian
|
|
Assignee | |
Comment 4•5 years ago
|
||
(In reply to Sebastian Zartner [:sebo] from comment #2)
There are currently no blocking bugs referenced. So, what's holding this from being shipped?
Sebastian
No blocking bugs. We are the first browser to support this, and I added a pref to protect this in the beginning because this is a chrome-only feature at that moment. Now it seems Webkit also supports this, per Comment 1, and the result of wpt.fyi, so it should be fine to ship this now.
Probably also need to add some parsing tests into wpt.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Change component to Layout because this is related to 2 different specs: path() is defined in CSS Shapes, and clip-path is defined in CSS Masking.
|
|
Assignee | |
Comment 6•5 years ago
|
||
I intend to ship this after soft code freeze (i.e. Firefox 71). However, devtools team won't support this for now.
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
Do you know what the CSS Working Group thinks about the feature's readiness to ship?
|
|
Assignee | |
Comment 10•5 years ago
•
|
||
(In reply to David Baron :dbaron: 🏴 ⌚UTC-7 from comment #9)
Do you know what the CSS Working Group thinks about the feature's readiness to ship?
No. I don't know. I didn't find the discussion about its readiness to ship. I only see the issue and git commit which adds path() in [css-shapes-2], and some people mentioned path() during the discussing of d attribute in svgwg #320.
It seems the git commit of adding path() didn't update the description of <basic-shape> in [css-shapes-2]. Perhaps they forgot. IMO, this spec should be updated to let the description of <basic-shape> also include <path>, to avoid confusing people. I can file a spec issue for this.
|
|
Assignee | |
Comment 11•5 years ago
•
|
||
Sorry, I'm not 100% sure when can we ship this. So should I hold these patches until we get the decision or any update from the CSS Working Group about path()?
Seems worth filing two issues: the first on the definition of <basic-shape> in shapes-2, and the other asking what the group thinks of shipping path() (pointing out that one implementation is already shipping it).
|
|
Assignee | |
Comment 13•5 years ago
|
||
I see. Thanks for the suggestion.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 14•5 years ago
|
||
It was resolved we can ship this. https://github.com/w3c/csswg-drafts/issues/4271#issuecomment-531681208
|
|
Assignee | |
Comment 15•5 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #14)
It was resolved we can ship this. https://github.com/w3c/csswg-drafts/issues/4271#issuecomment-531681208
Great! Thanks!
|
||
Comment 16•5 years ago
|
||
Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a44075d29ced Ship clip-path:path(). r=emilio https://hg.mozilla.org/integration/autoland/rev/0c7899578399 Add more tests for clip-path:path(). r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19093 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 19•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a44075d29ced
https://hg.mozilla.org/mozilla-central/rev/0c7899578399
Upstream PR merged by moz-wptsync-bot
|
||
Updated•5 years ago
|
Description
•