Closed Bug 1488585 Opened 6 years ago Closed 6 years ago

Support ImageRendering on list-style-image property

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox63 --- disabled
firefox64 --- fixed

People

(Reporter: h.winnemoeller, Assigned: h.winnemoeller)

References

Details

Attachments

(2 files, 2 obsolete files)

Firefox list-style-image moz crisp.html, not working on WR
327 bytes, text/html
Details
3-Bug_1488585___Use_ImageRendering_property_to_provide_proper_filtering_for_list_style_image_on_WR__r_nical.diff
1.56 KB, patch
Details | Diff | Splinter Review
STR: 1. Be on a new profile and set gfx.webrender.all to true. 2. Use the example code on https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-image. 3. Set the ul style to image-rendering: -moz-crisp-edges 4. Zoom the Page. JSFiddle for example: https://jsfiddle.net/nf4krsqh/4/ or see attachment "Firefox list-style-image moz crisp.html" Expected Results: Image is pixelated and has sharp edges. Actual Results: Image is blurry. --- During the creation of the WR command for the BulletRenderer, the ImageRendering argument is always set to "Auto", see https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/layout/generic/nsBulletFrame.cpp#500. Bug 1488555 requires the CreateImageKey call at https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/layout/generic/nsBulletFrame.cpp#489 to provide the actual ImageRendering property. Therefore, this variable can also be used at the PushImage call. I will attach a patch that applies the needed changes.
Depends on: 1488555
Assignee: nobody → h.winnemoeller
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9006393 - Flags: review?(nical.bugzilla) → review+
Has to be checked in once Bug 1488555 has landed.
Keywords: checkin-needed
Keywords: checkin-needed
Should only be checked in >after< Bug 1488555 has landed.
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a79ed7cdda37 Use ImageRendering property to provide proper filtering for list-style-image on WR. r=nical
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a79ed7cdda37
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: