Closed Bug 1488630 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12837 - Fix cases where setValueCurveAtTime was not throwing errors

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12837 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12837
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:
>  Fix cases where setValueCurveAtTime was not throwing errors
>  
>  Catch more cases where we should throw errors if a new
>  setValueCurveAtTime overlaps an existing setValueCurveAtTime event.
>  
>  Add some additional tests for more coverage.  Also, some of the
>  existing tests were using incorrect expected error types so fix them.
>  
>  Remove test expectations file since we pass now.
>  
>  Bug:879676
>  Test: the-audioparam-interface/audioparam-setValueCurve-exceptions.html
>  Change-Id: I14a7a7c9ab36955b7e084ca9148495860b661111
>  Reviewed-on: https://chromium-review.googlesource.com/1205719
>  WPT-Export-Revision: 19a9f76ff57042ea55f41306f3ffffb8c863ad42
PR 12837 applied with additional changes from upstream: 4fd41de6ecf73b21534c81fc0f516defdca50ab1, e4a0aa65f4e435a52fce48bd3f566b1749ae0150, 214201456566050d2c45db5e4806afe37f96b912, 7c50c216081d6ea3c9afe553ee7b64534020a1b2
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html
    
      Test Exceptions from setValueCurveAtTime
    : FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21977c553dfe
[wpt PR 12837] - Fix cases where setValueCurveAtTime was not throwing errors, a=testonly
https://hg.mozilla.org/mozilla-central/rev/21977c553dfe
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.