Closed Bug 1488700 Opened Last year Closed Last year

Some SVG rendering observer cleanup

Categories

(Core :: SVG, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(12 files)

46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
smaug
: review+
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
46 bytes, text/x-phabricator-request
longsonr
: review+
Details | Review
No description provided.
Comment on attachment 9006535 [details]
Bug 1488700 p1. Put the SVG rendering observer code in the mozilla namespace. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9006535 - Flags: review+
Comment on attachment 9006539 [details]
Bug 1488700 p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9006539 - Flags: review+
Comment on attachment 9006538 [details]
Bug 1488700 p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9006538 - Flags: review+
Comment on attachment 9006537 [details]
Bug 1488700 p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9006537 - Flags: review+
Comment on attachment 9006693 [details]
Bug 1488700 p5. Get rid of nsISVGFilterReference. r?smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9006693 - Flags: review+
Priority: -- → P3
Comment on attachment 9008263 [details]
Bug 1488700 p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9008263 - Flags: review+
Comment on attachment 9008259 [details]
Bug 1488700 p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9008259 - Flags: review+
Comment on attachment 9008257 [details]
Bug 1488700 p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9008257 - Flags: review+
Comment on attachment 9008253 [details]
Bug 1488700 p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9008253 - Flags: review+
Comment on attachment 9008254 [details]
Bug 1488700 p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9008254 - Flags: review+
Comment on attachment 9008256 [details]
Bug 1488700 p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9008256 - Flags: review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/606dc4110668
p1. Put the SVG rendering observer code in the mozilla namespace. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/647135eaa820
p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7762b8a9e1
p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/65aa2df88638
p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d38bc6936d2
p5. Get rid of nsISVGFilterReference. r=smaug
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/930b84a65d5f
p6. Rename nsSVGFilterReference to SVGFilterObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/609a4dc010e2
p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/de0e7c7fa57b
p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/7515890dcf10
p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/b03ab4cd857e
p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/78bef229b759
p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ef9297762c1
p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r=longsonr
I have a bunch more patches to clean up and post but I'll do that in separate bugs.
What happened to my review comment?
Flags: needinfo?(jwatt)
Oh, I messed up applying that, sorry. :/ I have a comments overhaul patch. I'll role it up into that.
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.