Closed
Bug 1488700
Opened 6 years ago
Closed 6 years ago
Some SVG rendering observer cleanup
Categories
(Core :: SVG, enhancement, P3)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(12 files)
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
smaug
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
Details | Review | |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
|
46 bytes,
text/x-phabricator-request
|
longsonr
:
review+
|
Details | Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D5022
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D5023
|
|
Assignee | |
Comment 4•6 years ago
|
||
Depends on D5024
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9006535 [details] Bug 1488700 p1. Put the SVG rendering observer code in the mozilla namespace. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9006535 -
Flags: review+
|
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9006539 [details] Bug 1488700 p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9006539 -
Flags: review+
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9006538 [details] Bug 1488700 p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9006538 -
Flags: review+
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9006537 [details] Bug 1488700 p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9006537 -
Flags: review+
|
|
Assignee | |
Comment 9•6 years ago
|
||
|
||
Comment 10•6 years ago
|
||
Comment on attachment 9006693 [details] Bug 1488700 p5. Get rid of nsISVGFilterReference. r?smaug Olli Pettay [:smaug] has approved the revision.
Attachment #9006693 -
Flags: review+
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 11•6 years ago
|
||
|
|
Assignee | |
Comment 12•6 years ago
|
||
Depends on D5617
|
|
Assignee | |
Comment 13•6 years ago
|
||
Depends on D5619
|
|
Assignee | |
Comment 14•6 years ago
|
||
Depends on D5620
|
|
Assignee | |
Comment 15•6 years ago
|
||
Depends on D5622
|
|
Assignee | |
Comment 16•6 years ago
|
||
Depends on D5623
|
|
Assignee | |
Comment 17•6 years ago
|
||
Depends on D5624
|
|
||
Comment 18•6 years ago
|
||
Comment on attachment 9008263 [details] Bug 1488700 p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9008263 -
Flags: review+
|
|
||
Comment 19•6 years ago
|
||
Comment on attachment 9008259 [details] Bug 1488700 p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9008259 -
Flags: review+
|
|
||
Comment 20•6 years ago
|
||
Comment on attachment 9008257 [details] Bug 1488700 p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9008257 -
Flags: review+
|
|
||
Comment 21•6 years ago
|
||
Comment on attachment 9008253 [details] Bug 1488700 p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9008253 -
Flags: review+
|
|
||
Comment 22•6 years ago
|
||
Comment on attachment 9008254 [details] Bug 1488700 p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9008254 -
Flags: review+
|
|
||
Comment 23•6 years ago
|
||
Comment on attachment 9008256 [details] Bug 1488700 p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9008256 -
Flags: review+
|
||
Comment 24•6 years ago
|
||
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/606dc4110668 p1. Put the SVG rendering observer code in the mozilla namespace. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/647135eaa820 p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7762b8a9e1 p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/65aa2df88638 p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/0d38bc6936d2 p5. Get rid of nsISVGFilterReference. r=smaug
|
|
||
Comment 25•6 years ago
|
||
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/930b84a65d5f p6. Rename nsSVGFilterReference to SVGFilterObserver. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/609a4dc010e2 p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/de0e7c7fa57b p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/7515890dcf10 p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/b03ab4cd857e p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/78bef229b759 p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/1ef9297762c1 p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r=longsonr
|
|
Assignee | |
Comment 26•6 years ago
|
||
I have a bunch more patches to clean up and post but I'll do that in separate bugs.
|
|
Assignee | |
Comment 28•6 years ago
|
||
Oh, I messed up applying that, sorry. :/ I have a comments overhaul patch. I'll role it up into that.
Flags: needinfo?(jwatt)
|
||
Comment 29•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/606dc4110668 https://hg.mozilla.org/mozilla-central/rev/647135eaa820 https://hg.mozilla.org/mozilla-central/rev/aa7762b8a9e1 https://hg.mozilla.org/mozilla-central/rev/65aa2df88638 https://hg.mozilla.org/mozilla-central/rev/0d38bc6936d2 https://hg.mozilla.org/mozilla-central/rev/930b84a65d5f https://hg.mozilla.org/mozilla-central/rev/609a4dc010e2 https://hg.mozilla.org/mozilla-central/rev/de0e7c7fa57b https://hg.mozilla.org/mozilla-central/rev/7515890dcf10 https://hg.mozilla.org/mozilla-central/rev/b03ab4cd857e https://hg.mozilla.org/mozilla-central/rev/78bef229b759 https://hg.mozilla.org/mozilla-central/rev/1ef9297762c1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•