1488700 - Some SVG rendering observer cleanup

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p1. Put the SVG rendering observer code in the mozilla namespace. r?longsonr

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r?longsonr

Depends on D5022

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r?longsonr

Depends on D5023

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r?longsonr

Depends on D5024

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 9006535 [details]
Bug 1488700 p1. Put the SVG rendering observer code in the mozilla namespace. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 6

[Robert Longson [:longsonr]]

Comment on attachment 9006539 [details]
Bug 1488700 p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 7

[Robert Longson [:longsonr]]

Comment on attachment 9006538 [details]
Bug 1488700 p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 8

[Robert Longson [:longsonr]]

Comment on attachment 9006537 [details]
Bug 1488700 p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 9

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p5. Get rid of nsISVGFilterReference. r?smaug

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9006693 [details]
Bug 1488700 p5. Get rid of nsISVGFilterReference. r?smaug

Olli Pettay [:smaug] has approved the revision.

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p6. Rename nsSVGFilterReference to SVGFilterObserver. r?longsonr

Comment 12

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r?longsonr

Depends on D5617

Comment 13

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r?longsonr

Depends on D5619

Comment 14

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r?longsonr

Depends on D5620

Comment 15

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r?longsonr

Depends on D5622

Comment 16

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r?longsonr

Depends on D5623

Comment 17

[Jonathan Watt [:jwatt]]

Attachment: Bug 1488700 p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r?longsonr

Depends on D5624

Comment 18

[Robert Longson [:longsonr]]

Comment on attachment 9008263 [details]
Bug 1488700 p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 19

[Robert Longson [:longsonr]]

Comment on attachment 9008259 [details]
Bug 1488700 p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 20

[Robert Longson [:longsonr]]

Comment on attachment 9008257 [details]
Bug 1488700 p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 21

[Robert Longson [:longsonr]]

Comment on attachment 9008253 [details]
Bug 1488700 p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 22

[Robert Longson [:longsonr]]

Comment on attachment 9008254 [details]
Bug 1488700 p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 23

[Robert Longson [:longsonr]]

Comment on attachment 9008256 [details]
Bug 1488700 p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/606dc4110668
p1. Put the SVG rendering observer code in the mozilla namespace. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/647135eaa820
p2. Rename nsSVGRenderingObservers to SVGRenderingObservers. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7762b8a9e1
p3. Rename nsSVGRenderingObserversList to SVGRenderingObserversList. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/65aa2df88638
p4. Rename nsSVGIDRenderingObserver to SVGIDRenderingObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d38bc6936d2
p5. Get rid of nsISVGFilterReference. r=smaug

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/930b84a65d5f
p6. Rename nsSVGFilterReference to SVGFilterObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/609a4dc010e2
p7. Rename nsSVGFilterChainObserver to SVGFilterObserverList. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/de0e7c7fa57b
p8. Rename CanvasFilterChainObserver to SVGFilterObserverListForCanvas. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/7515890dcf10
p9. Rename nsSVGFilterProperty to SVGFilterObserverListForCSSProp. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/b03ab4cd857e
p10. Rename nsSVGMarkerProperty to SVGMarkerObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/78bef229b759
p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ef9297762c1
p12. Rename nsSVGMaskProperty to SVGMaskObserverList. r=longsonr

Comment 26

[Jonathan Watt [:jwatt]]

I have a bunch more patches to clean up and post but I'll do that in separate bugs.

Comment 27

[Robert Longson [:longsonr]]

What happened to my review comment?

Comment 28

[Jonathan Watt [:jwatt]]

Oh, I messed up applying that, sorry. :/ I have a comments overhaul patch. I'll role it up into that.

Comment 29

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/606dc4110668
https://hg.mozilla.org/mozilla-central/rev/647135eaa820
https://hg.mozilla.org/mozilla-central/rev/aa7762b8a9e1
https://hg.mozilla.org/mozilla-central/rev/65aa2df88638
https://hg.mozilla.org/mozilla-central/rev/0d38bc6936d2
https://hg.mozilla.org/mozilla-central/rev/930b84a65d5f
https://hg.mozilla.org/mozilla-central/rev/609a4dc010e2
https://hg.mozilla.org/mozilla-central/rev/de0e7c7fa57b
https://hg.mozilla.org/mozilla-central/rev/7515890dcf10
https://hg.mozilla.org/mozilla-central/rev/b03ab4cd857e
https://hg.mozilla.org/mozilla-central/rev/78bef229b759
https://hg.mozilla.org/mozilla-central/rev/1ef9297762c1