148874 - document in the code why overlapping email preferences happen to work

Status: NEW

(Bugzilla :: Email Notifications, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

I said this over in bug 146261, comment 5:

---
No, because the code containing the elsifs runs once per change, so no change
matches more than one condition.  The only exception is status changes to
resolved or verified, which match both the 'The bug is resolved or verified' and
the 'Priority, status, severity, and/or milestone changes' preferences.

Since the former preference is more specific than the latter, however, it should
override it, so the elsifs work in that situation as well (but this should be
documented).
---

Comment 1

[Matthew Tuck [:CodeMachine]]

Erm, shouldn't that be document in the UI?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

No, I mean in the code, where we accidentally get the desired result (leaving us
susceptible to bug exposure if this code is ever hacked, hence my statement
about documenting it).

Comment 3

[Matthew Tuck [:CodeMachine]]

OK, well, it's also a UI issue, that people might think that status changes to
resolved or verified can get matched by either.

Comment 4

[Joel Peshkin]

These unloved bugs have been sitting untouched since June 2002 or longer.  If
nobody does anything else to them, they certainly won't make 2.18
Retargetting to 2.20.  If you really plan to push them right now, you might pull
them back in.

Comment 5

[Max Kanat-Alexander]

As preed is no longer actively working on Bugzilla (from what I know), I somehow
doubt that this bug will make it in for 2.20. :-) If I'm wrong, feel free to
take it back and re-target it. :-)