Closed
Bug 1488755
Opened 7 years ago
Closed 7 years ago
browser.xhtml: accessible/tests/mochitest/relations/test_tabbrowser.xul should use `children` instead of `childNodes`
Categories
(Firefox :: Tabbed Browser, enhancement)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
This was missed in Bug 1453783 - it uses `childNodes` which returns whitespace nodes in HTML and not in XUL: https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/accessible/tests/mochitest/relations/test_tabbrowser.xul#51-52.
|
Assignee | |
Comment 1•7 years ago
|
||
For browser.xhtml childNodes includes whitespace nodes, while browser.xul
doesn't. This was done with other mochitests that load the browser window
in Bug 1482667.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9006559 [details]
Bug 1488755 - Replace childNodes with children in test_tabbrowser.xul;r=yzen
Yura Zenevich [:yzen] has approved the revision.
Attachment #9006559 -
Flags: review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cd46cc28ae9
Replace childNodes with children in test_tabbrowser.xul;r=yzen
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•