browser.xhtml: accessible/tests/mochitest/relations/test_tabbrowser.xul should use `children` instead of `childNodes`

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
This was missed in Bug 1453783 - it uses `childNodes` which returns whitespace nodes in HTML and not in XUL: https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/accessible/tests/mochitest/relations/test_tabbrowser.xul#51-52.
(Assignee)

Comment 1

8 months ago
For browser.xhtml childNodes includes whitespace nodes, while browser.xul
doesn't. This was done with other mochitests that load the browser window
in Bug 1482667.
Comment on attachment 9006559 [details]
Bug 1488755 - Replace childNodes with children in test_tabbrowser.xul;r=yzen

Yura Zenevich [:yzen] has approved the revision.
Attachment #9006559 - Flags: review+

Comment 3

8 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cd46cc28ae9
Replace childNodes with children in test_tabbrowser.xul;r=yzen

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8cd46cc28ae9
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.