1488759 - BinaryArith ICs missing in gdocs

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[Ted Campbell [:tcampbell]]

One item from https://bugzilla.mozilla.org/show_bug.cgi?id=1488435#c3 is that a bunch of binary arithmetic ICs doing bit operations on >32-bit integers are failing to attach.

Comment 1

[Ted Campbell [:tcampbell]]

Matthew, can you take a look?

Comment 2

[Ted Campbell [:tcampbell]]

Examples in CacheIR logs

> {
>   "name":"BinaryArith",
>   "file":"https://www.google.com/js/bg/.js line 1 > Function",
>   "mode":0,
>   "line":3,
>   "column":4733,
>   "pc":"158e63ccab1",
>   "op":"ursh",
>   "rhs":{
>     "type":"int32",
>     "value":11
>   },
>   "lhs":{
>     "type":"number",
>     "value":"54772703898"
>   }
> },
> {
>   "name":"BinaryArith",
>   "file":"https://www.google.com/js/bg/.js line 1 > Function",
>   "mode":0,
>   "line":3,
>   "column":4733,
>   "pc":"158e63ccab7",
>   "op":"bitxor",
>   "rhs":{
>     "type":"number",
>     "value":"54772703898"
>   },
>   "lhs":{
>     "type":"number",
>     "value":"2890608493"
>   }
> },

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1488759 - [Part 1] Add IC support for bitwise ops on all Number x Number combinations r=tcampbell

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1488759 - [Part 2] Add IC support for bitwise shifts on Number x Number combinations r=tcampbell

Depends on D5060

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1488759 - Add IC support for bitwise ops on all Number x Number combinations r=tcampbell

Comment 7

[Ted Campbell [:tcampbell]]

Comment on attachment 9006699 [details]
Bug 1488759 - Add IC support for bitwise ops on all Number x Number combinations r=tcampbell

Ted Campbell [:tcampbell] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f6e36e7d6d6
Add IC support for bitwise ops on all Number x Number combinations r=tcampbell

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3f6e36e7d6d6