1488772 - Automatically generate media/ffvpx/config.h from FFmpeg configure script

Status: REOPENED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

We include a cut down copy of ffmpeg in media/ffvpx

We use a manually crafted config_xx.{h,asm} for each platforms we run out.

Generating those config files is very time intensive.

Ideally, we should run the original FFmpeg configure script and generate those at build time...

Comment 1

[Nathan Froyd [:froydnj]]

I don't think we want to add more configure script running to developer builds to regenerate the same information every time...

Comment 2

[Jean-Yves Avenard [:jya]]

Obviously, I would expect that configuration to only run if:
- It's never been run
- Some media/ffvpx/TOUCHME (or something) got modified.

not to run it every time you build

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

With :kmoir's consent, I'm reviewing the backlog for bugs in FFx Build System to see if we can do some things to clean up the backlog.

This bug appears to be an enhancement or feature request. If so, please set the bug's severity to `enhancement` and/or add the `feature` keyword depending on if this is an improvement to an existing thing, or a new feature/tool/system.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Per conversation with :kmoir, I'm going through untriaged bugs in her components and marking the ones which look to be enhancements/tasks with the enhancement severity to get them out of the triage queue.

If this incorrect, please remove the tag.

Comment 5

[(not currently active) Ted Mielczarek]

As filed this is definitely WONTFIX--we've removed all invocations of configure scripts for vendored third party projects because they're expensive to run and hard to integrate into the build. If maintaining these header files is time-consuming someone could look into running the ffmpeg configure script outside of the build system to generate them when updating the vendored copy of ffmpeg.

Comment 6

[(not currently active) Ted Mielczarek]

I'm going to go ahead and resolve this--we definitely wouldn't do this in the build system. If you want to do something at import time that automatically generates the checked-in files that would be fine. That bug can go in the Audio/Video component.

We have something similar for ICU where we build ICU at import time to generate the data file that we then commit:
https://dxr.mozilla.org/mozilla-central/source/intl/icu_sources_data.py

Comment 7

[Jean-Yves Avenard [:jya]]

we don't have to do this at build time.

right now it takes hours to craft those. so definitely want something automated