Disable content blocking introduction panel when using Marionette

RESOLVED FIXED in Firefox 64

Status

enhancement
P2
normal
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: davehunt, Assigned: whimboo)

Tracking

Version 3
mozilla65
Points:
---

Firefox Tracking Flags

(firefox64 fixed, firefox65 fixed)

Details

User Story

To get familiar with the Marionette test harness please check the following documentation:

https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html

Attachments

(2 attachments)

When navigating to a website that has content blocking enabled, Firefox shows a popup to explain the feature. We should disable this when Firefox is launched with Marionette enabled.

The intro panel is shown a maximum number of times, and we can disable it entirely by setting two preferences to indicate that it's already exceeded this number.

The preferences are defined here: https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/browser/base/content/browser-contentblocking.js#168-169

I would suggest setting both "browser.contentblocking.introCount" and "privacy.trackingprotection.introCount" to 99. The current maximum is set to 20.

These should be added in the following places:

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/components/marionette.js#54

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/client/marionette_driver/geckoinstance.py#33

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/geckodriver/src/prefs.rs
Dave, is this a preference which needs a restart of Firefox, or is it active right away once set?
Flags: needinfo?(dave.hunt)
Whiteboard: [lang=py]
Priority: -- → P3
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Dave, is this a preference which needs a restart of Firefox, or is it active
> right away once set?

It worked right away for me.
Flags: needinfo?(dave.hunt)
In that case we only have to modify those two locations:

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/components/marionette.js#54

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/client/marionette_driver/geckoinstance.py#504 (DesktopInstance, and not GeckoInstance)

If you don't mind I would take over the mentorship for this bug.
Mentor: dave.hunt → hskupin
User Story: (updated)
Whiteboard: [lang=py] → [lang=py][lang=js]

Comment 5

8 months ago
I am working on this bug, currently, I'm reading the https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html , please assign it to me, it's going to be my first bug in Mozilla, it will take a while but this looks do-able to me.
Hi gurungrahul2, and thank you for your interest in working on this bug. It's noted, but we generally assign bugs once a first patch has been uploaded. Please let me know when you have questions, or troubles.
Hello :Henrik,

I am a beginner and this looks like a very good bug for me. However :gurungrahul2 is working on it. Please let me know if I am allowed to submit a patch. Otherwise, let me know if :gurungrahul2 is not able to come up with a patch.

Comment 8

8 months ago
(In reply to Kajal Kumari Sah (:kajalsah) from comment #7)
> Hello :Henrik,
> 
> I am a beginner and this looks like a very good bug for me. However
> :gurungrahul2 is working on it. Please let me know if I am allowed to submit
> a patch. Otherwise, let me know if :gurungrahul2 is not able to come up with
> a patch.

I got a little busy on work and academics, have you made any progress ? We can help each other if you have made changes.
Flags: needinfo?(kajalksah07)
This is actually kinda nasty when investigating problems on websites which are using all kinds of tracking methods. I will just add those prefs myself.
Assignee: nobody → hskupin
Mentor: hskupin
Status: NEW → ASSIGNED
Flags: needinfo?(kajalksah07)
Keywords: good-first-bug
Priority: P3 → P2
Summary: Disable content blocking popup when using Marionette → Disable content blocking and tracking protection introduction panels when using Marionette
(In reply to Dave Hunt [:davehunt] ⌚️UTC+1 from comment #0)
> I would suggest setting both "browser.contentblocking.introCount" and
> "privacy.trackingprotection.introCount" to 99. The current maximum is set to
> 20.

When implementing this feature I noticed that "privacy.trackingprotection.introCount" doesn't exist anymore. Was this a temporary addition, and got removed again? Not a single result is returned by searchfox when searching for it.

As such this bug will only cover the content blocking introduction panel.
Summary: Disable content blocking and tracking protection introduction panels when using Marionette → Disable content blocking introduction panel when using Marionette

Comment 12

7 months ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86787c8d2a26
[marionette] Disable content blocking introduction panel. r=ato
Whiteboard: [lang=py][lang=js]

Comment 13

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86787c8d2a26
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Please uplift this test-only patch to mozilla-beta, so we can prevent the introduction panel for people testing real websites.
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.