1488826 - Disable content blocking introduction panel when using Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

When navigating to a website that has content blocking enabled, Firefox shows a popup to explain the feature. We should disable this when Firefox is launched with Marionette enabled.

The intro panel is shown a maximum number of times, and we can disable it entirely by setting two preferences to indicate that it's already exceeded this number.

The preferences are defined here: https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/browser/base/content/browser-contentblocking.js#168-169

I would suggest setting both "browser.contentblocking.introCount" and "privacy.trackingprotection.introCount" to 99. The current maximum is set to 20.

These should be added in the following places:

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/components/marionette.js#54

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/client/marionette_driver/geckoinstance.py#33

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/geckodriver/src/prefs.rs

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Screen Shot 2018-09-05 at 17.15.12.png

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave, is this a preference which needs a restart of Firefox, or is it active right away once set?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Dave, is this a preference which needs a restart of Firefox, or is it active
> right away once set?

It worked right away for me.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In that case we only have to modify those two locations:

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/components/marionette.js#54

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/testing/marionette/client/marionette_driver/geckoinstance.py#504 (DesktopInstance, and not GeckoInstance)

If you don't mind I would take over the mentorship for this bug.

Comment 5

[gurungrahul2]

I am working on this bug, currently, I'm reading the https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html , please assign it to me, it's going to be my first bug in Mozilla, it will take a while but this looks do-able to me.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi gurungrahul2, and thank you for your interest in working on this bug. It's noted, but we generally assign bugs once a first patch has been uploaded. Please let me know when you have questions, or troubles.

Comment 7

[Kajal Kumari Sah (:kajalsah)]

Hello :Henrik,

I am a beginner and this looks like a very good bug for me. However :gurungrahul2 is working on it. Please let me know if I am allowed to submit a patch. Otherwise, let me know if :gurungrahul2 is not able to come up with a patch.

Comment 8

[gurungrahul2]

(In reply to Kajal Kumari Sah (:kajalsah) from comment #7)
> Hello :Henrik,
> 
> I am a beginner and this looks like a very good bug for me. However
> :gurungrahul2 is working on it. Please let me know if I am allowed to submit
> a patch. Otherwise, let me know if :gurungrahul2 is not able to come up with
> a patch.

I got a little busy on work and academics, have you made any progress ? We can help each other if you have made changes.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is actually kinda nasty when investigating problems on websites which are using all kinds of tracking methods. I will just add those prefs myself.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Dave Hunt [:davehunt] ⌚️UTC+1 from comment #0)
> I would suggest setting both "browser.contentblocking.introCount" and
> "privacy.trackingprotection.introCount" to 99. The current maximum is set to
> 20.

When implementing this feature I noticed that "privacy.trackingprotection.introCount" doesn't exist anymore. Was this a temporary addition, and got removed again? Not a single result is returned by searchfox when searching for it.

As such this bug will only cover the content blocking introduction panel.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1488826 - [marionette] Disable content blocking introduction panel. r?ato

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86787c8d2a26
[marionette] Disable content blocking introduction panel. r=ato

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/86787c8d2a26

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please uplift this test-only patch to mozilla-beta, so we can prevent the introduction panel for people testing real websites.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b42d14602aa