46 bytes, text/x-phabricator-request
|Details | Review|
While testing bug 1393570 I found that new windows and new tabs default to about:newtab even in private browsing mode. When the window is in private browsing mode, the default should be about:privatebrowsing. This expected behavior is the case when a new private tab/window is opened manually by the user.
That's strange, because I notice new windows opening with about:privatebrowsing in tests I've done for bug 1345474.
on second thought, I might not using webext apis to open windows.
This is actually a regression, and should be fixed before Beta is promoted to stable. ...and windows.create for non-private browsing windows should be about:home (but that is not a regression). https://phabricator.services.mozilla.com/D4929#inline-20894
I'm mistaken, this is not a regression. Unlike windows.create, tabs.create does not use newTabService. The default hoempage of windows.create is still broken though, both for private and non-private windows.
Use a homepage URL instead of a new tab URL by default in browser.windows.create.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c844033d55eb Use about:home / about:privatebrowsing in windows.create r=rpl,dao
Backed out changeset c844033d55eb (Bug 1488914) for bc failures in /browser_ext_windows_create_cookieStoreId.js. Backout: https://hg.mozilla.org/integration/autoland/rev/04fbac02c101394f6b344a695e81bdfb026151a1 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending,running,success,testfailed,busted,exception&revision=c844033d55eb91acb4190ee202361b1b95062e0c&selectedJob=204838242 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204838242&repo=autoland&lineNumber=3660
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cf62153b17ad Use about:home / about:privatebrowsing in windows.create r=rpl,dao
Verified that the issue is no longer occurring on: FF 64.0b3, Nightly 65.0a1 running on Windows 10 x64, using both browser's controls and tab management extensions.
You need to log in before you can comment on or make changes to this bug.