Migrate toolbox-process-window.xul to HTML

RESOLVED FIXED in Firefox 64

Status

P3
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: bgrins, Assigned: Honza)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 64

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
Spinning this out from a discussion with Honza:

https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-process-window.xul

- I believe this is doable. We can port the <commandset> in it and the toolbox-window to just hook up key shortcuts directly, and I'd also need to look more closely at mainPopupSet but AFAICT that's unused now.
- We can probably also remove a number of the scripts loaded at the top.
- We could either `hg mv toolbox-process-window.xul toolbox-process-window.xhtml` and then keep default ns as XUL, as we do with browser.xhtml, or porting most of the markup to HTML and keeping XUL only as needed.
- We may consider porting the XULStore data from the old path the to new (so size/location info stays persisted).
Assignee: nobody → odvarko
Thanks for the report Brian, let's try to remove a bit more XUL!
I am attaching first try for review.

The module would deserve some code cleanup, but we can do it after...

Honza
Ah, also, we might want to try to remove some of the scripts.
Honza
Created attachment 9007233 [details]
Bug 1488915 - Migrate toolbox-process-window.xul to HTML; r=bgrins
(Reporter)

Comment 6

5 months ago
Comment on attachment 9007233 [details]
Bug 1488915 - Migrate toolbox-process-window.xul to HTML; r=bgrins

Brian Grinstead [:bgrins] has approved the revision.
Attachment #9007233 - Flags: review+

Comment 7

4 months ago
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50eedf887f96
Migrate toolbox-process-window.xul to HTML; r=bgrins

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/50eedf887f96
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.