Closed Bug 1488949 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 12857 - Change detune min/max limits

Categories

(Core :: Web Audio, enhancement, P4)

Product:
Core
Component:
Web Audio
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12857 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12857 Details from upstream follow. Raymond Toy <rtoy@chromium.org> wrote: > Change detune min/max limits > > The max and min valures for the OscillatorNode.detune parameter has been > reduced according the latest version of the spec. Make it so. > > Also implement clamping of the total frequency to Nyquist so that we don't > generate infinity or NaN doing the computations. This is ok because anything > beyond Nyquist would output 0 anyway. But we're careful to preserve the slope > of automations; test added for this as well. > > Update expectations for AudioParam/audioparam-nominal-range.html because of > the new warnings produced by clamping detune. > > Bug: 865552, 860347 > Test: the-oscillatornode-interface/detune-limiting.html > Change-Id: I35a214b0f3156ad8912718dcb277f1967f70df8f > Reviewed-on: https://chromium-review.googlesource.com/1138638 > WPT-Export-Revision: 52355712c3ea44e01654f36e24b243f5d8343b18
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 13 subtests OK : 1 PASS : 8 FAIL : 5 New tests that have failures or other problems: /webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting.html # AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed.: FAIL < [detune automation] 1 out of 3 assertions were failed.: FAIL < [detune limits] 1 out of 4 assertions were failed.: FAIL X Osc(freq: 44100.00390625) output: Expected 0 for all values but found 5511 unexpected values: Index Actual [1] 1.7484555314695172e-7 [2] 1.7484555314695172e-7 [3] 1.7484555314695172e-7 [4] 1.7484555314695172e-7 ...and 5507 more errors.: FAIL X osc[5:]: Expected 0 for all values but found 5507 unexpected values: Index Actual [0] 0.0007123791729100049 [1] 0.0008548549376428127 [2] 0.0009973307605832815 [3] 0.0011398064671084285 ...and 5503 more errors.: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/75500a069ab8 [wpt PR 12857] - Change detune min/max limits, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/03ac979218c6 [wpt PR 12857] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/75500a069ab8 https://hg.mozilla.org/mozilla-central/rev/03ac979218c6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.