1489010 - Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nicholas Nethercote [inactive]]

These properties were added in bug 478251 back when XPIDL was sort of emulating
WebIDL. They are not needed any more, and none of our XPIDL files use them.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes

Comment 2

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a89f0af8fffd6ecd3b83b6406ba80bd24c5f2b38

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 9006760 [details] [diff] [review]
Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes

Review of attachment 9006760 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really qualified to review in here. It looks trivially correct to me, but let's ask someone who knows XPIDL a bit better...

Comment 4

[Nicholas Nethercote [inactive]]

Ok. I asked you because you reviewed their addition in bug 478251 (and bz is on PTO). That bug was nine years ago, though... :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00056b5eb714
Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes. r=jorendorff

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/00056b5eb714