Closed
Bug 1489010
Opened 6 years ago
Closed 6 years ago
Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
These properties were added in bug 478251 back when XPIDL was sort of emulating WebIDL. They are not needed any more, and none of our XPIDL files use them.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9006760 -
Flags: review?(jorendorff)
Assignee | ||
Comment 2•6 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a89f0af8fffd6ecd3b83b6406ba80bd24c5f2b38
Comment 3•6 years ago
|
||
Comment on attachment 9006760 [details] [diff] [review] Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes Review of attachment 9006760 [details] [diff] [review]: ----------------------------------------------------------------- I'm not really qualified to review in here. It looks trivially correct to me, but let's ask someone who knows XPIDL a bit better...
Attachment #9006760 -
Flags: review?(jorendorff) → review?(nika)
Assignee | ||
Comment 4•6 years ago
|
||
Ok. I asked you because you reviewed their addition in bug 478251 (and bz is on PTO). That bug was nine years ago, though... :)
Updated•6 years ago
|
Attachment #9006760 -
Flags: review?(nika) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00056b5eb714 Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes. r=jorendorff
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/00056b5eb714
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•