Closed Bug 1489010 Opened Last year Closed Last year

Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file)

These properties were added in bug 478251 back when XPIDL was sort of emulating
WebIDL. They are not needed any more, and none of our XPIDL files use them.
Comment on attachment 9006760 [details] [diff] [review]
Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes

Review of attachment 9006760 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really qualified to review in here. It looks trivially correct to me, but let's ask someone who knows XPIDL a bit better...
Attachment #9006760 - Flags: review?(jorendorff) → review?(nika)
Ok. I asked you because you reviewed their addition in bug 478251 (and bz is on PTO). That bug was nine years ago, though... :)
Attachment #9006760 - Flags: review?(nika) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00056b5eb714
Remove XPIDL support for `Null` and `Undefined` value-taking properties on `DOMString` parameters and attributes. r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/00056b5eb714
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.