1489015 - Remove nsAbsoluteItems::AddChild()

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P4)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

nsAbsoluteItems::AddChild() is not virtual, so it is not used at all except by ConstructBackdropFrameFor() [1]. I don't feel we need to make it virtual. I think we can remove it, and add an assertion that an out-of-flow frame must have placeholder frame in nsFrameItems::AddChild(). 

[1] https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/layout/base/nsCSSFrameConstructor.cpp#1249

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1489015 - Remove nsAbsoluteItems::AddChild() and add an assertion in nsFrameItems::AddChild()

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1489015 - Make NS_NewPlaceholderFrame() return nsPlaceholderFrame* to avoid type casting

Depends on D5112

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9006782 [details]
Bug 1489015 - Remove nsAbsoluteItems::AddChild() and add an assertion in nsFrameItems::AddChild()

Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9006783 [details]
Bug 1489015 - Make NS_NewPlaceholderFrame() return nsPlaceholderFrame* to avoid type casting

Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f3759c5666e
Remove nsAbsoluteItems::AddChild() and add an assertion in nsFrameItems::AddChild() r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/9c147d3c4ef9
Make NS_NewPlaceholderFrame() return nsPlaceholderFrame* to avoid type casting r=bzbarsky

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7f3759c5666e
https://hg.mozilla.org/mozilla-central/rev/9c147d3c4ef9