1489091 - Remove support for the inputtooltiptext attribute

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, task, P5)

Description

[Dão Gottwald [:dao]]

This appears to be unused:

https://searchfox.org/mozilla-central/search?q=inputtooltiptext&case=true

Let's remove xbl:inherits="tooltiptext=inputtooltiptext" from autocomplete.xml.

Comment 1

[Preeti[:preeti]]

Hello everyone! I would like to work on this issue in case no one is working on it. Thanks in advance!

Comment 2

[Dão Gottwald [:dao]]

(In reply to Preeti[:preeti] from comment #1)
> Hello everyone! I would like to work on this issue in case no one is working
> on it. Thanks in advance!

Go ahead!

Comment 3

[Preeti[:preeti]]

(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to Preeti[:preeti] from comment #1)
> > Hello everyone! I would like to work on this issue in case no one is working
> > on it. Thanks in advance!
> 
> Go ahead!
I am getting the following output while pushing my code on Phabricator:

Linting...
No lint engine configured for this project.
Running unit tests...
 Exception 
Command failed with error #255!
COMMAND
HGPLAIN=1 hg diff --git -U32767 --rev '' -- ''

STDOUT
(empty)

STDERR
hg: parse error: empty query

(Run with `--trace` for a full exception trace.)

please help!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I asked on irc, and it looks like you may have forgotten to commit the changes?

21:46 <imadueme> emilio: it looks like that contributor didn't commit their changes first? hg was unable to find any difference

Comment 5

[Preeti[:preeti]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
> I asked on irc, and it looks like you may have forgotten to commit the
> changes?
> 
> 21:46 <imadueme> emilio: it looks like that contributor didn't commit their
> changes first? hg was unable to find any difference

Thank you for your help,but I have commited all the changes.....however I tried pushing my patch from an old clone Mozilla Central, there, it is not reflecting any changes in the file after making my changes and using hg status  after that. Please help!

Comment 6

[Preeti[:preeti]]

Attachment: Bug 1489091 - Remove support for the inputtooltiptext attribute; r?dao

Remove support for the inputtooltiptext attribute

Comment 7

[Preeti[:preeti]]

I have submitted my patch on a new clone...I have taken help from the #introduction channel...Please do let me know if any further changes are required. Thanks in advance!

Comment 8

[Preeti[:preeti]]

(In reply to Preeti[:preeti] from comment #7)
> I have submitted my patch on a new clone...I have taken help from the
> #introduction channel...Please do let me know if any further changes are
> required. Thanks in advance!

I have incorporated the changes mentioned in the Phabricator review and had submitted a patch yesterday. Please do review and let me know if I need to make any further changes!

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9008990 [details]
Bug 1489091 - Remove support for the inputtooltiptext attribute; r?dao

Dão Gottwald [::dao] has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8854f79600bb
Remove support for the inputtooltiptext attribute; r=dao

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8854f79600bb