Closed
Bug 1489102
Opened 6 years ago
Closed 6 years ago
Add supports for encrypted flac in MSE/EME
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
46 bytes,
text/x-phabricator-request
|
bryce
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
bryce
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
bryce
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
bryce
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
bryce
:
review+
|
Details | Review |
We've hardcoded the list of usable audio codec usable to aac, opus and vorbis... This prevents the use of flac.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jyavenard
Assignee | ||
Comment 1•6 years ago
|
||
temp fix, will do a full one once upstream change is merged
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D5198
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D5205
Updated•6 years ago
|
Attachment #9007041 -
Attachment description: Bug 1489102 - P1. mp4parse-rust resync → Bug 1489102 - P1. mp4parse-rust resync to f6032a118aa498525145adf611cd7b3bec0e0216
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Interestingly, with samples < 2s I get timeout with some of the mochitest, but not otherwise. I'm suspecting a problem elsewhere, either in the test themselves or in our code... looks like a racy behaviour and could explain a few intermittents we have with the eme tests.
Comment on attachment 9007041 [details] Bug 1489102 - P1. mp4parse-rust resync to f6032a118aa498525145adf611cd7b3bec0e0216 Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9007041 -
Flags: review+
Comment on attachment 9007061 [details] Bug 1489102 - P2. Add mochitests. r?bryce Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9007061 -
Flags: review+
Comment on attachment 9007065 [details] Bug 1489102 - P3. Allow flac and opus in mp4 for EME. r?bryce Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9007065 -
Flags: review+
Comment on attachment 9007162 [details] Bug 1489102 - P4. Add flac in mp4 plain file test. r?bryce Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9007162 -
Flags: review+
Assignee | ||
Comment 10•6 years ago
|
||
This leads to audio content having negative start time
Comment on attachment 9007311 [details] Bug 1489102 - P5. Ensure the Opus decoder never returns an empty sample. r?bryce Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9007311 -
Flags: review+
Comment 12•6 years ago
|
||
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/70224e316a2c P1. mp4parse-rust resync to f6032a118aa498525145adf611cd7b3bec0e0216 r=bryce https://hg.mozilla.org/integration/autoland/rev/256bc4a68c8b P2. Add mochitests. r=bryce https://hg.mozilla.org/integration/autoland/rev/97a4b939d30a P3. Allow flac and opus in mp4 for EME. r=bryce
Comment 13•6 years ago
|
||
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e789da8f1255 P4. Add flac in mp4 plain file test. r=bryce
Comment 14•6 years ago
|
||
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7497ffc7b996 P5. Ensure the Opus decoder never returns an empty sample. r=bryce
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70224e316a2c https://hg.mozilla.org/mozilla-central/rev/256bc4a68c8b https://hg.mozilla.org/mozilla-central/rev/97a4b939d30a https://hg.mozilla.org/mozilla-central/rev/e789da8f1255 https://hg.mozilla.org/mozilla-central/rev/7497ffc7b996
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•