1489102 - Add supports for encrypted flac in MSE/EME

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

We've hardcoded the list of usable audio codec usable to aac, opus and vorbis...

This prevents the use of flac.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1489102 - P1. mp4parse-rust resync to f6032a118aa498525145adf611cd7b3bec0e0216

temp fix, will do a full one once upstream change is merged

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1489102 - P2. Add mochitests. r?bryce

Depends on D5198

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1489102 - P3. Allow flac and opus in mp4 for EME. r?bryce

Depends on D5205

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1489102 - P4. Add flac in mp4 plain file test. r?bryce

Comment 5

[Jean-Yves Avenard [:jya]]

Interestingly, with samples < 2s I get timeout with some of the mochitest, but not otherwise.

I'm suspecting a problem elsewhere, either in the test themselves or in our code... looks like a racy behaviour and could explain a few intermittents we have with the eme tests.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9007041 [details]
Bug 1489102 - P1. mp4parse-rust resync to f6032a118aa498525145adf611cd7b3bec0e0216

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9007061 [details]
Bug 1489102 - P2. Add mochitests. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9007065 [details]
Bug 1489102 - P3. Allow flac and opus in mp4 for EME. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9007162 [details]
Bug 1489102 - P4. Add flac in mp4 plain file test. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 10

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1489102 - P5. Ensure the Opus decoder never returns an empty sample. r?bryce

This leads to audio content having negative start time

Comment 11

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9007311 [details]
Bug 1489102 - P5. Ensure the Opus decoder never returns an empty sample. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70224e316a2c
P1. mp4parse-rust resync to f6032a118aa498525145adf611cd7b3bec0e0216 r=bryce
https://hg.mozilla.org/integration/autoland/rev/256bc4a68c8b
P2. Add mochitests. r=bryce
https://hg.mozilla.org/integration/autoland/rev/97a4b939d30a
P3. Allow flac and opus in mp4 for EME. r=bryce

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e789da8f1255
P4. Add flac in mp4 plain file test. r=bryce

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7497ffc7b996
P5. Ensure the Opus decoder never returns an empty sample. r=bryce

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/70224e316a2c
https://hg.mozilla.org/mozilla-central/rev/256bc4a68c8b
https://hg.mozilla.org/mozilla-central/rev/97a4b939d30a
https://hg.mozilla.org/mozilla-central/rev/e789da8f1255
https://hg.mozilla.org/mozilla-central/rev/7497ffc7b996