1489196 - Some perf issues with the domain code in ContentPrincipal::Read

Status: RESOLVED FIXED

(Core :: Security: CAPS, enhancement)

Description

[Jan de Mooij [:jandem]]

Some issues with the SetDomain call in ContentPrincipal::Read:

(1) SetDomain calls SetHasExplicitDomain unconditionally, but Read usually passes a nullptr domain so we unnecessarily deoptimize later checks.

(2) I think we don't need the wrapper recomputation in SetDomain when called from Read because we just created the principal.

I'm Try-servering a patch.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1489196 - Don't call SetDomain in ContentPrincipal::Read. r?bholley

This fixes two issues:

1) We no longer SetHasExplicitDomain() when the domain is null.
2) We avoid the unnecessary (because new principal) wrapper recomputation.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 9006964 [details]
Bug 1489196 - Don't call SetDomain in ContentPrincipal::Read. r?bholley

Bobby Holley (:bholley) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50313b936f90
Don't call SetDomain in ContentPrincipal::Read. r=bholley

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/50313b936f90