Closed
Bug 1489220
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Tests: check "Nothing yet" is displayed when debug target category is empty
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
Check that nothing yet is displayed if a category is expanded but empty. Check that the message disappears when a debug target is created.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
I am having doubts about adding a test for this at the moment. If we use the "This Firefox" runtime in order to test this, we need to pick a debug target pane which we trust to test that (and that we can bring to 0 debug targets). - tabs: impossible because there will always at least be the aboutdebugging target - extensions: right now we still list the system addons (see Bug 1488499) so impossible to control as well - workers: can we really assume no workers will ever be setup by default/ Temporary extensions seem to be the best category to assert this, but this is still a workaround more than a proper test. Ideally we should be able to have a mock here were we can completely control the tabs, workers and addons output. I think it might make sense to start wrapping the client objects we are dealing with in the application in order to introduce a MockClient that we can use for tests. Short of that I will try something with temporary extensions.
Assignee | ||
Comment 2•6 years ago
|
||
Updated•6 years ago
|
Priority: P3 → P1
Comment 3•6 years ago
|
||
Comment on attachment 9010951 [details] Bug 1489220 - Add mochitest for empty message in debug target pane;r=daisuke Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9010951 -
Flags: review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/650083b7ab81 Add mochitest for empty message in debug target pane;r=daisuke
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/650083b7ab81
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•