1489340 - Remove xpt.py

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nicholas Nethercote [inactive]]

Since the big xptinfo overhaul earlier this year, it's no longer needed.

This change will involve:

- Removing xpt.py.

- Updating two tests:
  - python/mozbuild/mozpack/test/test_packager_formats.py
  - python/mozbuild/mozpack/test/test_packager_unpack.py

- Adjusting the mozpack code.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1489340 - Handle XPT files as blobs of data in packager. r=froydnj

We don't actually ship XPT files anymore, but it's still useful for the
packager code to handle old Firefox versions. But for that, we don't
really need the complexity of "linking" XPT files in a single unit per
directory. We can just as well keep the XPT files intact, as long as we
retain individual `interfaces` manifest entries for each.

And since those entries used to be all merged into one, we now instead
group them all together in manifests (which also happens to make it
easier on unit test changes).

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1489340 - Remove xpcom/typelib

Nothing is using the xpt module anymore, which means we can remove it,
as well as the runtests.py script that runs its test, and the
integration of those tests in the build system.

Depends on D5221

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 9007103 [details]
Bug 1489340 - Handle XPT files as blobs of data in packager. r=froydnj

Nathan Froyd [:froydnj] has approved the revision.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 9007106 [details]
Bug 1489340 - Remove xpcom/typelib

Nathan Froyd [:froydnj] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae2483247797
Handle XPT files as blobs of data in packager. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/79fe4634f866
Remove xpcom/typelib r=froydnj

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ae2483247797
https://hg.mozilla.org/mozilla-central/rev/79fe4634f866