Closed Bug 1489340 Opened Last year Closed Last year

Remove xpt.py

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: glandium)

Details

Attachments

(2 files)

Since the big xptinfo overhaul earlier this year, it's no longer needed.

This change will involve:

- Removing xpt.py.

- Updating two tests:
  - python/mozbuild/mozpack/test/test_packager_formats.py
  - python/mozbuild/mozpack/test/test_packager_unpack.py

- Adjusting the mozpack code.
Assignee: nobody → mh+mozilla
We don't actually ship XPT files anymore, but it's still useful for the
packager code to handle old Firefox versions. But for that, we don't
really need the complexity of "linking" XPT files in a single unit per
directory. We can just as well keep the XPT files intact, as long as we
retain individual `interfaces` manifest entries for each.

And since those entries used to be all merged into one, we now instead
group them all together in manifests (which also happens to make it
easier on unit test changes).
Attachment #9007103 - Attachment description: Bug 1489340 - Handle XPT files as blobs of data in packager. r?build → Bug 1489340 - Handle XPT files as blobs of data in packager
Nothing is using the xpt module anymore, which means we can remove it,
as well as the runtests.py script that runs its test, and the
integration of those tests in the build system.

Depends on D5221
Comment on attachment 9007103 [details]
Bug 1489340 - Handle XPT files as blobs of data in packager. r=froydnj

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9007103 - Flags: review+
Comment on attachment 9007106 [details]
Bug 1489340 - Remove xpcom/typelib

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9007106 - Flags: review+
Attachment #9007103 - Attachment description: Bug 1489340 - Handle XPT files as blobs of data in packager → Bug 1489340 - Handle XPT files as blobs of data in packager. r=froydnj
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/ae2483247797
Handle XPT files as blobs of data in packager. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/79fe4634f866
Remove xpcom/typelib r=froydnj
https://hg.mozilla.org/mozilla-central/rev/ae2483247797
https://hg.mozilla.org/mozilla-central/rev/79fe4634f866
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.