1489387 - Have fullscreenerror events also aligned to the refresh driver tick

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1489387 - Have fullscreenerror event aligned to refresh driver tick. r=smaug

Depends on D5235

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Ok, there is no explanation why

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Apparently HTML spec requires this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

ahaa, need to review bug 1489385 first.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9007141 [details]
Bug 1489387 - Have fullscreenerror event aligned to refresh driver tick. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ed98e49718c
Have fullscreenerror event aligned to refresh driver tick. r=smaug

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for element-request-fullscreen-active-document.html failures. 

backout:  https://hg.mozilla.org/integration/autoland/rev/0cf3f2b65be0b66b44baaea3bbade5565f03fbf6

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4ed98e49718c8a2de6cc3060de6dcb81cf0aa8c6&filter-searchStr=wpt9&selectedJob=198190083

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=198190083&repo=autoland&lineNumber=2147

[task 2018-09-08T01:19:53.794Z] 01:19:53     INFO - TEST-START | /fullscreen/api/element-request-fullscreen-active-document.html
[task 2018-09-08T01:19:53.946Z] 01:19:53     INFO - 
[task 2018-09-08T01:19:53.946Z] 01:19:53     INFO - TEST-UNEXPECTED-PASS | /fullscreen/api/element-request-fullscreen-active-document.html | Element#requestFullscreen() when the document is not the active document - expected FAIL
[task 2018-09-08T01:19:53.946Z] 01:19:53     INFO - TEST-INFO | expected FAIL
[task 2018-09-08T01:19:53.946Z] 01:19:53     INFO - TEST-OK | /fullscreen/api/element-request-fullscreen-active-document.html | took 151ms
[task 2018-09-08T01:19:53.967Z] 01:19:53     INFO - PID 6186 | 1536369593962	Marionette	INFO	Stopped listening on port 2828
[task 2018-09-08T01:19:53.968Z] 01:19:53     INFO - PID 6186 | JavaScript error: resource://activity-stream/lib/TopSitesFeed.jsm, line 86: TypeError: setting getter-only property "_currentSearchHostname"
[task 2018-09-08T01:19:54.327Z] 01:19:54     INFO - PID 6186 | JavaScript error: resource:///modules/AsyncTabSwitcher.jsm, line 256: TypeError: browser.frameLoader is null
[task 2018-09-08T01:19:54.409Z] 01:19:54     INFO - Browser exited with return code 0
[task 2018-09-08T01:19:54.410Z] 01:19:54  WARNING - u'runner_teardown': ()
[task 2018-09-08T01:19:54.428Z] 01:19:54     INFO - Setting up ssl
[task 2018-09-08T01:19:54.448Z] 01:19:54     INFO - certutil | 
[task 2018-09-08T01:19:54.476Z] 01:19:54     INFO - certutil | 
[task 2018-09-08T01:19:54.492Z] 01:19:54     INFO - certutil | 
[task 2018-09-08T01:19:54.492Z] 01:19:54     INFO - Certificate Nickname                                         Trust Attributes
[task 2018-09-08T01:19:54.493Z] 01:19:54     INFO -                                                              SSL,S/MIME,JAR/XPI
[task 2018-09-08T01:19:54.493Z] 01:19:54     INFO - 
[task 2018-09-08T01:19:54.493Z] 01:19:54     INFO - web-platform-tests                                           CT,, 
[task 2018-09-08T01:19:54.493Z] 01:19:54     INFO - 
[task 2018-09-08T01:19:54.509Z] 01:19:54     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpW7kNi5.mozrunner
[task 2018-09-08T01:19:54.525Z] 01:19:54     INFO - Starting runner
[task 2018-09-08T01:19:56.439Z] 01:19:56     INFO - PID 6411 | 1536369596435	Marionette	INFO	Listening on port 2828
[task 2018-09-08T01:19:56.720Z] 01:19:56     INFO - TEST-START | /fullscreen/api/element-request-fullscreen-not-allowed.html
[task 2018-09-08T01:19:56.742Z] 01:19:56     INFO - Setting pref full-screen-api.unprefix.enabled (true)
[task 2018-09-08T01:19:56.906Z] 01:19:56     INFO - .
[task 2018-09-08T01:19:56.906Z] 01:19:56     INFO - TEST-OK | /fullscreen/api/element-request-fullscreen-not-allowed.html | took 184ms

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Note to myself: the test was not supposed to be failing either, so take a look why it was. The meta should at least be made to depend on the unprefixed api pref.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

So I had another look at the test, and yes, both the failure (before the patch) and the pass (after the patch) are expected.

The test checks that fullscreenerror event is not dispatched for an inactive document. Before this patch, we queue the event to the event loop, so it is dispatched regardless. After this patch, we queue it on the refresh driver, and thus it only gets dispatched when the document is active.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7d043d64466
Have fullscreenerror event aligned to refresh driver tick. r=smaug

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d7d043d64466