1489458 - Stop console.log'ing the world in browser.js' startup code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Gijs (he/him)]

Creating console objects and logging to them isn't free (cf. bug 1486885 comment 10). And on mobile, 99.999999% of users will never see the messages. So doing it by default on mobile in a startup method seems like a waste of time.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds like a possible performance benefit and not too difficult.

Comment 2

[Brad Arant]

Attachment: Bug 1489458 - Clean up log messages for debugging on browser.js.;r?VladBaicu

Comment 3

[Brad Arant]

This patch removes the obvious debug and extraneous 'informational' messages in the browser.js file. I left exception handling log entries as those will be needed.

Comment 4

[Brad Arant]

Attachment: Bug 1489458 - Reduce extraneous console logging from browser.js;r?VladBaicu

Comment 5

[Brad Arant]

Attachment: Bug 1489458 - Update to re-add message and changed it to console.warn.;r?VladBaicu

Depends on D35213

Comment 6

[Brad Arant]

Submitted patch to keep requested message and change to console.warn.

Comment 7

[Brad Arant]

Attachment: Bug 1489458 - Remove extraneous console logging in browser.js.;r?VladBaicu

Comment 8

[Brad Arant]

Please check-in.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b788a1f2f095
Remove extraneous console logging in browser.js.;r=VladBaicu

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b788a1f2f095

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 12

[Chris Peterson [:cpeterson]]

Gijs, should we uplift this console spam fix to Fennec ESR 68? There will be no Fennec 69 release. Fennec users will be switched to the ESR 68 channel for the next 6-12 months, so the only way to release a fix to Fennec users will be to uplift to ESR.

Comment 13

[:Gijs (he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #12)

Gijs, should we uplift this console spam fix to Fennec ESR 68? There will be no Fennec 69 release. Fennec users will be switched to the ESR 68 channel for the next 6-12 months, so the only way to release a fix to Fennec users will be to uplift to ESR.

I guess so, doing so is risk-free, as all we're doing is removing some extraneous logging. Probably best if the patch author or reviewer does the uplift request though.

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to :Gijs (he/him) from comment #13)

I guess so, doing so is risk-free, as all we're doing is removing some extraneous logging. Probably best if the patch author or reviewer does the uplift request though.

Sounds good. "Risk-free" is nice. :)

Brad or Vlad, can you please request uplift to Fennec ESR 68 when you have a chance?

Comment 15

[Brad Arant]

Comment on attachment 9074687 [details]
Bug 1489458 - Remove extraneous console logging in browser.js.;r?VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Low impact on final release.
• User impact if declined: Extra logging message that may slow performance.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only impact to logging. No logic changes.
• String or UUID changes made by this patch:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9074687 [details]
Bug 1489458 - Remove extraneous console logging in browser.js.;r?VladBaicu

Removes some extraneous logging which can cause perf issues. Approved for Fennec 68.1b1.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/bff36fbf2628