Closed Bug 1489487 Opened Last year Closed Last year

[wpt-sync] Sync PR 12895 - Implement DTMF [[ToneBuffer]] in the blink layer

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12895 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12895
Details from upstream follow.

Harald Alvestrand <hta@chromium.org> wrote:
>  Implement DTMF [[ToneBuffer]] in the blink layer
>  
>  This CL makes the Blink layer keep a copy of the tone buffer
>  and update it on insertDTMF and ontonechange events only; this
>  makes it possible to expose the state of the tone buffer at the
>  time the event is fired to the Javascript callback.
>  
>  It removes a queueing step inside the DTMF sender, because
>  that queueing step destroyed the consistency.
>  
>  Bug: chromium:816475
>  Change-Id: I5aa68396299a67d6cea1e8a17d364f553514c291
>  Reviewed-on: https://chromium-review.googlesource.com/1213084
>  WPT-Export-Revision: 7a601819ca51a2dc6af6014fca63f7837ed3f477
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 3 tests and 8 subtests
OK     : 2
PASS   : 7
FAIL   : 1

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/058710dfff1d
[wpt PR 12895] - Implement DTMF [[ToneBuffer]] in the blink layer, a=testonly
https://hg.mozilla.org/mozilla-central/rev/058710dfff1d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.