1489487 - [wpt-sync] Sync PR 12895 - Implement DTMF [[ToneBuffer]] in the blink layer

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12895 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12895
Details from upstream follow.

Harald Alvestrand <[e-mail]> wrote:
>  Implement DTMF [[ToneBuffer]] in the blink layer
>  
>  This CL makes the Blink layer keep a copy of the tone buffer
>  and update it on insertDTMF and ontonechange events only; this
>  makes it possible to expose the state of the tone buffer at the
>  time the event is fired to the Javascript callback.
>  
>  It removes a queueing step inside the DTMF sender, because
>  that queueing step destroyed the consistency.
>  
>  Bug: chromium:816475
>  Change-Id: I5aa68396299a67d6cea1e8a17d364f553514c291
>  Reviewed-on: https://chromium-review.googlesource.com/1213084
>  WPT-Export-Revision: 7a601819ca51a2dc6af6014fca63f7837ed3f477

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1951f09832f84b4502a80c6b8170adb702e2fc48

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dd9ebdffc56e7f4d412de4666558c8e23819b71

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=baef0767f9c1028a574ade0c376ea41dacd3690c

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8f2d209ae9ebe348f678f22ff3c82e4364648a8

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d4b6ba8328e10c46b5cd75a3699296d00b62b98

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6b523e1369bfa30b462d2e25bfe67abc258a533

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ebe3a5a90e314466001c0cee7e4c09a883bede6

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=796a2c5715ffc9d77c5376507f25276481ac2036

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 3 tests and 8 subtests
OK     : 2
PASS   : 7
FAIL   : 1

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f0b695d255cef88606b3901b9e498f2f10f449

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/058710dfff1d
[wpt PR 12895] - Implement DTMF [[ToneBuffer]] in the blink layer, a=testonly

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/058710dfff1d