1489507 - Treeherder won't load older pushes more than once

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Dorel Luca [:dluca]]

When going to the bottom of the treehderder page, pressing on either one of the buttons, it only works once.
Once the next 10, 20 or 50 pushes have been loaded and I click again one of the buttons it will simply not load anything.

As emorly suggested I opened the console to check for network issues, any 500, there were none.

Other sheriffs have reported the same issue.

Comment 1

[Ed Morley [:emorley]]

Sorry for the breakage - I've rolled back production to the previous deploy so if you refresh this should be resolve. 

(@camd: I using Heroku's rollback feature rather than pushing to the production branch, to see how that compared - was super quick since doesn't need to rebuild)

Comment 2

[Ed Morley [:emorley]]

(I could repro with that STR)

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1488869 touches code in the method called by the eventListener for these buttons.

https://github.com/mozilla/treeherder/commit/edbc680937b68a99e8dcb1179bd2d4b5f9bfb68e#diff-2137849303d386ac6bef97a399416499L110

Comment 4

[Cameron Dawson [:camd]]

I'll work on this right away.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4001

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2a48b96dea05467310a3203bcd115177786c8128
Bug 1489507 - Fix not loading older pushes more than once

Comment 7

[Andreea Pavel [:apavel]]

Ed, Cameron: i still have an issue here. When opening a new revision and loading more pushes, the second time, they do not load. (investigating fresh oranges for example)

Steps to repro:

Access: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending,running,success,testfailed,busted,exception&classifiedState=unclassified&fromchange=7ac9b5094f7edd86a109db287ff2a0c1097caed7&searchStr=linux,x64,debug,spidermonkey,builds,spidermonkey-sm-compacting-linux64%2Fdebug,sm(cgc)

2. click on load 10/20/50 more pushes (either one)
3. wait for the pushes to load then click on the last revision loaded
4. after the revision opens, click again to load more pushes
5. after the pushes load, go again to the end of the page and try to load more pushes -> nothing happens

***note: there is sometimes an error displayed after step no 2, but the page changes too fast to see what it is

From the inspector when i click on load more pushes and they do not load:

Console: https://irccloud.mozilla.com/file/h0Fb5Kdr/image.png 

Nwtwork: https://irccloud.mozilla.com/file/1y73uWCM/image.png

I got to this issue today. Can you please take a look?

Comment 8

[Ed Morley [:emorley]]

Hi! That sounds like bug 1491532.

Comment 9

[Andreea Pavel [:apavel]]

Ah, thanks Ed!