1489522 - Possible typo in sizeof expression in builtin/Promise.cpp, and builtin/Array.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Bartlensky [:rbartlensky]]

Coverity points out that the usage of `this` is suspicious in the `sizeof` expression here: https://searchfox.org/mozilla-central/source/js/src/builtin/Promise.cpp#4322

`this` is a pointer, if the author really intended to use `this`, wouldn't it make more sense to use `void*`, so that the intention is clearer? If it is indeed a typo, then I guess the fix is to use `*this` instead of `this`.

Comment 1

[Tooru Fujisawa [:arai]]

yes, it should be *this, or just "PromiseLookup".
ArraySpeciesLookup::reset has the same issue.

are you going to post patch?

Comment 2

[Robert Bartlensky [:rbartlensky]]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> yes, it should be *this, or just "PromiseLookup".
> ArraySpeciesLookup::reset has the same issue.
> 
> are you going to post patch?

Yes, I will also fix the array one here if that is fine with you.

Comment 3

[Tooru Fujisawa [:arai]]

(In reply to Robert Bartlensky [:rbartlensky] from comment #2)
> (In reply to Tooru Fujisawa [:arai] from comment #1)
> > yes, it should be *this, or just "PromiseLookup".
> > ArraySpeciesLookup::reset has the same issue.
> > 
> > are you going to post patch?
> 
> Yes, I will also fix the array one here if that is fine with you.

I'm happy if you fix both of them.  thanks! :D

Comment 4

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1489522: Fix sizeof typos in js/src/builtin/Promise.cpp and js/src/builtin/Array.cpp.

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 9007251 [details]
Bug 1489522: Fix sizeof typos in js/src/builtin/Promise.cpp and js/src/builtin/Array.cpp.

Tooru Fujisawa [:arai] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60c37c0e5083
Fix sizeof typos in js/src/builtin/Promise.cpp and js/src/builtin/Array.cpp. r=arai

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/60c37c0e5083