1489588 - Keep TextOverflows on the stack

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1489588 - Disallow nsDisplayList copies and implement moves r?mattwoodrow

nsDisplayLists are currently a little bit error prone, since the
empty state of an nsDisplayList requires mTop == &mSentinel.
since &mSentinel will change when copied, while mTop won't,
this naturally creates an invalid state. Additionally, copies
don't quite make sense, since there is a requirement in the
destructor that destructed nsDisplayLists are empty - in which
case we would have to empty both the copied and the original
nsDisplayList - something which is unlikely to happen naturally.
Moves however are a natural operation - we just need to implement
the correct move behavior accounting for this mTop == &mSentinel
requirement.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1489588 - Allocate TextOverflows inline r?mattwoodrow

Once the nsDisplayList difficulties are sorted out, this
becomes rather trivial.

Depends on D5293

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9007312 [details]
Bug 1489588 - Disallow nsDisplayList copies and implement moves r?mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9007313 [details]
Bug 1489588 - Allocate TextOverflows inline r?mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0d64a94fb66
Disallow nsDisplayList copies and implement moves r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/718cbdccb64e
Allocate TextOverflows inline r=mattwoodrow

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a0d64a94fb66
https://hg.mozilla.org/mozilla-central/rev/718cbdccb64e