Closed Bug 1489588 Opened Last year Closed Last year

Keep TextOverflows on the stack

Categories

(Core :: Web Painting, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dthayer, Assigned: dthayer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxperf:p1])

Attachments

(2 files)

No description provided.
nsDisplayLists are currently a little bit error prone, since the
empty state of an nsDisplayList requires mTop == &mSentinel.
since &mSentinel will change when copied, while mTop won't,
this naturally creates an invalid state. Additionally, copies
don't quite make sense, since there is a requirement in the
destructor that destructed nsDisplayLists are empty - in which
case we would have to empty both the copied and the original
nsDisplayList - something which is unlikely to happen naturally.
Moves however are a natural operation - we just need to implement
the correct move behavior accounting for this mTop == &mSentinel
requirement.
Once the nsDisplayList difficulties are sorted out, this
becomes rather trivial.

Depends on D5293
Comment on attachment 9007312 [details]
Bug 1489588 - Disallow nsDisplayList copies and implement moves r?mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.
Attachment #9007312 - Flags: review+
Comment on attachment 9007313 [details]
Bug 1489588 - Allocate TextOverflows inline r?mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.
Attachment #9007313 - Flags: review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0d64a94fb66
Disallow nsDisplayList copies and implement moves r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/718cbdccb64e
Allocate TextOverflows inline r=mattwoodrow
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a0d64a94fb66
https://hg.mozilla.org/mozilla-central/rev/718cbdccb64e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.