Closed
Bug 1489590
Opened 7 years ago
Closed 7 years ago
Teach the URL classifier about the fastblock lists
Categories
(Toolkit :: Safe Browsing, enhancement, P1)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: francois, Assigned: francois)
References
Details
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
dimi
:
review+
pascalc
:
approval-mozilla-beta+
|
Details | Review |
In order to make it easy for the FastBlock Shield experiment and future uplift, let's ensure that the URL classifier knows where to find the lists.
Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9007317 [details]
Bug 1489590 - Teach the URL classifier about the FastBlock lists. r?dimi
Dimi Lee[:dimi][:dlee] has approved the revision.
Attachment #9007317 -
Flags: review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d72e61dfdb9
Teach the URL classifier about the FastBlock lists. r=dimi
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 9007317 [details]
Bug 1489590 - Teach the URL classifier about the FastBlock lists. r?dimi
Approval Request Comment
[Feature/Bug causing the regression]: FastBlock
[User impact if declined]: This will be necessary for us to be able to ship FastBlock with a different list than the default tracking protection list.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes. With this change, I have confirmed that we can successfully download any of the FastBlock lists.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: By itself it doesn't do anything. It only tells Firefox about a few more tracking protection lists that are available on our server backend, without downloading or using them in any way.
[String changes made/needed]: None
Attachment #9007317 -
Flags: approval-mozilla-beta?
Comment 6•7 years ago
|
||
Comment on attachment 9007317 [details]
Bug 1489590 - Teach the URL classifier about the FastBlock lists. r?dimi
Uplift approved for 63 beta 5.
Attachment #9007317 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•7 years ago
|
||
bugherder uplift |
status-firefox63:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•