1489613 - Landing fails when there are no warnings

Status: RESOLVED FIXED

(Conduit :: Lando, defect)

Description

[Connor Sheehan [:sheehan]]

I have attempted to land the stack ending in D4388 via the beta series landing API at https://lando.services.mozilla.com/D4388/. All the patches are reviewed, so I click the large green "preview landing" button in the bottom right corner. I preview the landing and at the bottom of the preview I ensure there are no warnings to acknowledge. I click "land" in the bottom left and after a moment I am sent back to https://lando.services.mozilla.com/D4388/ with a large red error message which reads: "Landing failed: The warnings present when the request was constructed have changed. Please acknowledge the new warnings and try again."

Comment 1

[Steven MacLeod [:smacleod]]

Looks like we're sending an empty string as the confirmation token and Lando API is expecting null. Going to update things so that Lando API will except either to mean no confirmation.

Comment 2

[Steven MacLeod [:smacleod]]

Attachment: transplants: accept empty string as null confirmation_token (Bug 1489613).

This fixes a bug where the current series UI doesn't allow landing
when there are no warnings.

Comment 3

[Tom Prince [:tomprince]]

Comment on attachment 9007345 [details]
transplants: accept empty string as null confirmation_token (Bug 1489613).

Tom Prince [:tomprince] has approved the revision.