Closed
Bug 1489807
Opened 7 years ago
Closed 7 years ago
Port bug 1489793, replace usage of XPCOM to create the spell checker object with Components.utils
Categories
(MailNews Core :: Composition, task)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: ehsan.akhgari, Assigned: darktrojan)
References
Details
Attachments
(1 file)
|
1006 bytes,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
The XPCOM component registration for nsIEditorSpellCheck is going away, and instead we will have a Components.utils API for creating the spellchecker object.
There is one usage of this component registration in comm-central:
https://dxr.mozilla.org/comm-central/rev/e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/editor/ui/dialogs/content/EdSpellCheck.js#26
Please see https://phabricator.services.mozilla.com/D5371#change-NV6Dun4rb9h6 for a sample of the change needed.
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9007710 [details] [diff] [review]
1489807-spellcheck-create-1.diff
Thanks, but we need to wait for bug 1489793 to get the Components.utils API.
Attachment #9007710 -
Flags: review?(jorgk) → review+
|
Reporter | |
Comment 3•7 years ago
|
||
The patches for bug 1489793 are on inbound now.
|
|
Reporter | |
Comment 4•7 years ago
|
||
This was just relanded on inbound after being backed out.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4bcb46410184
Port bug 1489793: replace usage of XPCOM to create the spell checker object. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 64.0
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•