1489914 - Fix UA override for rakuten.co.jp on Firefox Android

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, enhancement, P1)

Description

[Karl Dubost💡 :karlcow]

+++ This bug was initially created as a clone of Bug #1385206 +++

When accessing rakuten.co.jp on Firefox Android, we receive a desktop version.
http://www.rakuten.co.jp/

The initial UA override was wrong 
As explained in https://bugzilla.mozilla.org/show_bug.cgi?id=958411#c23


https://dxr.mozilla.org/mozilla-central/rev/c2e3be6a1dd352b969a45f0b85e87674e24ad284/mobile/android/app/ua-update.json.in#18,19


`Firefox.+$#`

needs to be replaced by

`Firefox.+$# `

to be effective.

Comment 1

[Karl Dubost💡 :karlcow]

This needs to be fixed and/or double checked if the UA override is actually necessary.
The site is working on RDM.

Comment 2

[Mike Taylor [:miketaylr]]

(oops)

Comment 3

[Mike Taylor [:miketaylr]]

(wow, i am terrible at this)

Comment 4

[Mike Taylor [:miketaylr]]

Attachment: 0001-But-1489914-Fix-UA-override-for-rakuten.co.jp.-r-kar.patch

Just verified that we do in fact need the override to get the mobile site.

Comment 5

[Karl Dubost💡 :karlcow]

Comment on attachment 9023462 [details] [diff] [review]
0001-But-1489914-Fix-UA-override-for-rakuten.co.jp.-r-kar.patch

Thanks Mike! r+

Comment 6

[Mike Taylor [:miketaylr]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3b2151392c
Fix UA override for rakuten.co.jp. r=karlcow

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5e3b2151392c