1489934 - accessible/tests/browser/events/browser_test_docload.js calls waitForEvents incorrectly

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P3)

Description

[James Teh [:Jamie] (away returning 14 Apr)]

Bug 1378257 changed waitForEvents (in accessible/tests/browser/events.js) so that instead of taking a separate argument for unexpected events:
-function waitForEvents(events, unexpected = [], ordered = false) {
it now takes both lists of events as a single argument:
+function waitForEvents(events, ordered = false) {
+  let expected = events.expected || events;
+  let unexpected = events.unexpected || [];
It looks like an existing test at that time wasn't updated:
https://searchfox.org/mozilla-central/source/accessible/tests/browser/events/browser_test_docload.js#38
It still calls waitForEvents with two lists:
let onLoadEvents = waitForEvents([
    [EVENT_REORDER, getAccessible(browser)],
...
  ], [ // unexpected
    [EVENT_DOCUMENT_LOAD_COMPLETE, inIframeChecker("iframe1")],
...

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1489934 - accessible/tests/browser/events/browser_test_docload.js calls waitForEvents incorrectly, r=jamie

Comment 2

[James Teh [:Jamie] (away returning 14 Apr)]

Comment on attachment 9007704 [details]
Bug 1489934 - accessible/tests/browser/events/browser_test_docload.js calls waitForEvents incorrectly, r=jamie

James Teh [:Jamie] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83022b462d0b
accessible/tests/browser/events/browser_test_docload.js calls waitForEvents incorrectly, r=Jamie

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/83022b462d0b