Enable ESLint for editor/

RESOLVED FIXED in Firefox 64

Status

()

P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 months ago
As part of expanding ESLint around the tree we should do the same for editor. I think this only will affect test files.

I'm currently working on a series of patches to do this.
(Assignee)

Comment 1

3 months ago
Created attachment 9008191 [details]
Bug 1489980 - Editor ESLint for editor/ - Initial setup adding configs for tests.

Also block-disables no-multi-spaces for test_resizers_resizing_elements.html
(Assignee)

Comment 2

3 months ago
Created attachment 9008192 [details]
Bug 1489980 - Enable ESLint for editor/ - automatic fixes

These are all automatically generated by ESLint with the --fix option.

Depends on D5584
(Assignee)

Comment 3

3 months ago
Created attachment 9008194 [details]
Bug 1489980 - Enable ESLint for editor/ - Manual fixes.

This enables the editor directory to be linted, and fixes the remaining issues raised by ESLint. Various rules were fixed here including, no-shadow, no-undef, no-unused-vars and others.

I've generally gone conservative, disabling rules where it doesn't make sense to fix them (e.g. sometimes suggests use-services for tests, but it is only used once, or within a Chrome script).

Depends on D5585
Comment on attachment 9008191 [details]
Bug 1489980 - Editor ESLint for editor/ - Initial setup adding configs for tests.

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9008191 - Flags: review+
Comment on attachment 9008194 [details]
Bug 1489980 - Enable ESLint for editor/ - Manual fixes.

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9008194 - Flags: review+
Makoto-san should know this change.
Priority: -- → P3
When do you land them? These patches are block my work/landings...
Flags: needinfo?(standard8)
(Assignee)

Comment 9

3 months ago
(In reply to Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) from comment #8)
> When do you land them? These patches are block my work/landings...

Sorry, somehow I'd managed to miss requesting review from you on the second part, so I only requested that from you yesterday: https://phabricator.services.mozilla.com/D5585

Once that's reviewed, these will be ready to land.
Flags: needinfo?(standard8)
Ah, I see, I didn't realize the review request (I want r? sync with Phabricator and bugzilla). I'll do it soon (it needs really long time...)
Comment on attachment 9008192 [details]
Bug 1489980 - Enable ESLint for editor/ - automatic fixes

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9008192 - Flags: review+

Comment 12

3 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea73513d7c25
Editor ESLint for editor/ - Initial setup adding configs for tests. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/de36f39840c6
Enable ESLint for editor/ - automatic fixes r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0d8eb8a0c2b4
Enable ESLint for editor/ - Manual fixes. r=masayuki

Comment 13

3 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d081dbefe2f
Enable ESLint for editor/ - Follow-up: Remove unused Ci. r=eslint-fix on a CLOSED TREE

Comment 14

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ea73513d7c25
https://hg.mozilla.org/mozilla-central/rev/de36f39840c6
https://hg.mozilla.org/mozilla-central/rev/0d8eb8a0c2b4
https://hg.mozilla.org/mozilla-central/rev/4d081dbefe2f
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.