1489980 - Enable ESLint for editor/

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Mark Banner (:standard8)]

As part of expanding ESLint around the tree we should do the same for editor. I think this only will affect test files.

I'm currently working on a series of patches to do this.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1489980 - Editor ESLint for editor/ - Initial setup adding configs for tests.

Also block-disables no-multi-spaces for test_resizers_resizing_elements.html

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1489980 - Enable ESLint for editor/ - automatic fixes

These are all automatically generated by ESLint with the --fix option.

Depends on D5584

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1489980 - Enable ESLint for editor/ - Manual fixes.

This enables the editor directory to be linted, and fixes the remaining issues raised by ESLint. Various rules were fixed here including, no-shadow, no-undef, no-unused-vars and others.

I've generally gone conservative, disabling rules where it doesn't make sense to fix them (e.g. sometimes suggests use-services for tests, but it is only used once, or within a Chrome script).

Depends on D5585

Comment 4

[Mark Banner (:standard8)]

Try push for the three patches combined: https://treeherder.mozilla.org/#/jobs?repo=try&revision=222a91fbfe467ce34ad7738dc5aa878cdb2cf803

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9008191 [details]
Bug 1489980 - Editor ESLint for editor/ - Initial setup adding configs for tests.

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9008194 [details]
Bug 1489980 - Enable ESLint for editor/ - Manual fixes.

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Makoto-san should know this change.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When do you land them? These patches are block my work/landings...

Comment 9

[Mark Banner (:standard8)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) from comment #8)
> When do you land them? These patches are block my work/landings...

Sorry, somehow I'd managed to miss requesting review from you on the second part, so I only requested that from you yesterday: https://phabricator.services.mozilla.com/D5585

Once that's reviewed, these will be ready to land.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, I see, I didn't realize the review request (I want r? sync with Phabricator and bugzilla). I'll do it soon (it needs really long time...)

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9008192 [details]
Bug 1489980 - Enable ESLint for editor/ - automatic fixes

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea73513d7c25
Editor ESLint for editor/ - Initial setup adding configs for tests. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/de36f39840c6
Enable ESLint for editor/ - automatic fixes r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0d8eb8a0c2b4
Enable ESLint for editor/ - Manual fixes. r=masayuki

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d081dbefe2f
Enable ESLint for editor/ - Follow-up: Remove unused Ci. r=eslint-fix on a CLOSED TREE

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ea73513d7c25
https://hg.mozilla.org/mozilla-central/rev/de36f39840c6
https://hg.mozilla.org/mozilla-central/rev/0d8eb8a0c2b4
https://hg.mozilla.org/mozilla-central/rev/4d081dbefe2f