Closed Bug 1490048 Opened 2 years ago Closed 1 year ago

Add a Cranelift line to AWFY


(Testing Graveyard :: AWFY, enhancement)

Not set


(firefox67 fixed)

Tracking Status
firefox67 --- fixed


(Reporter: bbouvier, Assigned: jmaher)


(Blocks 1 open bug)



(1 file, 2 obsolete files)

... once it's landed in Spidermonkey (bug 1469027).

I'll provide the extra information (about:config pref, extra configure options) when everything is ready.
Cranelift has now landed and can be built with --enable-cranelift at configure time (it's set by default for Nightly builds) and it can be enabled by default by setting the following about:config prefs:

javascript.options.wasm_baselinejit := false
javascript.options.wasm_cranelift := true

Joel, can we have this new "Cranelift" configuration running on Raptor/perfherder/AWFY, on Linux64 for WasmMisc, please? Thanks!
Flags: needinfo?(jmaher)
add a cranelift version of the wasm-misc test
thanks for the request, waiting on try and review :)
Flags: needinfo?(jmaher)
Thank *you* for getting to it so quickly!
:bbouvier- setting these prefs didn't seem to work:

you can see the wm-c jobs are orange, any thoughts on this?
Flags: needinfo?(bbouvier)
Crap, didn't realize that there's one benchmark in this suite that will iloop because of an issue in Cranelift ( ). Will ping you once it's fixed and integrated in Spidermonkey, sorry for the noise.
Flags: needinfo?(bbouvier)
Attachment #9013303 - Attachment is obsolete: true
Issue 335 seems to have been fixed upstream.
Yes, we're now working on a version bump in Spidermonkey.

Some time has spent, and Cranelift has been updated (lately in bug 1532689), so the crashes we were observing when running with Cranelift should now be fixed.

Joel, could we try running this again on try, to see if it still timeouts, please?

Flags: needinfo?(jmaher)

Yes, that looks correct. Can we also have results for the Godot wasm benchmark, please?

Flags: needinfo?(jmaher)

Thanks for checking! I think Cranelift doesn't run in Godot, though, according to these results. Could we have a raptor-wasm-godot-cranelift-firefox opt that runs with the same about:config prefs as Cranelift for wasm misc, please?

Flags: needinfo?(jmaher)

It is easy for you to add these options as well based on the patch I have provided in the try run :)

I have done this, here is a try push for you to look at:

Flags: needinfo?(jmaher)

Great, that looks good to go, thanks!

add cranelift to raptor wasm-misc and wasm-godot tests

add cranelift to raptor wasm-misc and wasm-godot tests.

Attachment #9050311 - Attachment is obsolete: true
Attachment #9050311 - Attachment is obsolete: false
Attachment #9050302 - Attachment is obsolete: true
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.