Add a Cranelift line to AWFY

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
8 months ago
2 months ago

People

(Reporter: bbouvier, Assigned: jmaher)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

8 months ago
... once it's landed in Spidermonkey (bug 1469027).

I'll provide the extra information (about:config pref, extra configure options) when everything is ready.
Reporter

Comment 1

8 months ago
Cranelift has now landed and can be built with --enable-cranelift at configure time (it's set by default for Nightly builds) and it can be enabled by default by setting the following about:config prefs:

javascript.options.wasm_baselinejit := false
javascript.options.wasm_cranelift := true

Joel, can we have this new "Cranelift" configuration running on Raptor/perfherder/AWFY, on Linux64 for WasmMisc, please? Thanks!
Flags: needinfo?(jmaher)
Assignee

Comment 2

8 months ago
add a cranelift version of the wasm-misc test
Assignee

Comment 3

8 months ago
thanks for the request, waiting on try and review :)
Flags: needinfo?(jmaher)
Reporter

Comment 4

8 months ago
Thank *you* for getting to it so quickly!
Assignee

Comment 5

8 months ago
:bbouvier- setting these prefs didn't seem to work:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=202615505&revision=4b315476dd1031aa427d061488abc75485c1151c

you can see the wm-c jobs are orange, any thoughts on this?
Flags: needinfo?(bbouvier)
Reporter

Comment 6

8 months ago
Crap, didn't realize that there's one benchmark in this suite that will iloop because of an issue in Cranelift ( https://github.com/CraneStation/cranelift/issues/335 ). Will ping you once it's fixed and integrated in Spidermonkey, sorry for the noise.
Flags: needinfo?(bbouvier)
Attachment #9013303 - Attachment is obsolete: true
Issue 335 seems to have been fixed upstream.
Reporter

Comment 8

7 months ago
Yes, we're now working on a version bump in Spidermonkey.
Reporter

Comment 9

2 months ago

Some time has spent, and Cranelift has been updated (lately in bug 1532689), so the crashes we were observing when running with Cranelift should now be fixed.

Joel, could we try running this again on try, to see if it still timeouts, please?

Flags: needinfo?(jmaher)
Reporter

Comment 11

2 months ago

Yes, that looks correct. Can we also have results for the Godot wasm benchmark, please?

Flags: needinfo?(jmaher)
Reporter

Comment 13

2 months ago

Thanks for checking! I think Cranelift doesn't run in Godot, though, according to these results. Could we have a raptor-wasm-godot-cranelift-firefox opt that runs with the same about:config prefs as Cranelift for wasm misc, please?

Flags: needinfo?(jmaher)
Assignee

Comment 14

2 months ago

It is easy for you to add these options as well based on the patch I have provided in the try run :)

I have done this, here is a try push for you to look at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=044b42c3246129c95baada670bce7112db19890a

Flags: needinfo?(jmaher)
Reporter

Comment 15

2 months ago

Great, that looks good to go, thanks!

Assignee

Comment 16

2 months ago

add cranelift to raptor wasm-misc and wasm-godot tests

Assignee

Comment 17

2 months ago

add cranelift to raptor wasm-misc and wasm-godot tests.

Attachment #9050311 - Attachment is obsolete: true
Attachment #9050311 - Attachment is obsolete: false
Attachment #9050302 - Attachment is obsolete: true

Comment 18

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → jmaher
You need to log in before you can comment on or make changes to this bug.