1490048 - Add a Cranelift line to AWFY

Status: RESOLVED FIXED

(Testing Graveyard :: AWFY, enhancement)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

... once it's landed in Spidermonkey (bug 1469027).

I'll provide the extra information (about:config pref, extra configure options) when everything is ready.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Cranelift has now landed and can be built with --enable-cranelift at configure time (it's set by default for Nightly builds) and it can be enabled by default by setting the following about:config prefs:

javascript.options.wasm_baselinejit := false
javascript.options.wasm_cranelift := true

Joel, can we have this new "Cranelift" configuration running on Raptor/perfherder/AWFY, on Linux64 for WasmMisc, please? Thanks!

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1490048 - Add a Cranelift line to AWFY. r=rwood

add a cranelift version of the wasm-misc test

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the request, waiting on try and review :)

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Thank *you* for getting to it so quickly!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

:bbouvier- setting these prefs didn't seem to work:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=202615505&revision=4b315476dd1031aa427d061488abc75485c1151c

you can see the wm-c jobs are orange, any thoughts on this?

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Crap, didn't realize that there's one benchmark in this suite that will iloop because of an issue in Cranelift ( https://github.com/CraneStation/cranelift/issues/335 ). Will ping you once it's fixed and integrated in Spidermonkey, sorry for the noise.

Comment 7

[Tom S [:evilpie]]

Issue 335 seems to have been fixed upstream.

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Yes, we're now working on a version bump in Spidermonkey.

Comment 9

[Benjamin Bouvier [:bbouvier] (inactive)]

Some time has spent, and Cranelift has been updated (lately in bug 1532689), so the crashes we were observing when running with Cranelift should now be fixed.

Joel, could we try running this again on try, to see if it still timeouts, please?

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

this seems to be working:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=7c012c9043b04c35c4472b169d22fc813808daab&newProject=try&newRevision=7c012c9043b04c35c4472b169d22fc813808daab&framework=10

if this is what is expected, do followup here and we can get this running.

Comment 11

[Benjamin Bouvier [:bbouvier] (inactive)]

Yes, that looks correct. Can we also have results for the Godot wasm benchmark, please?

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

ok, godot is added :)

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=7c012c9043b04c35c4472b169d22fc813808daab&newProject=try&newRevision=7c012c9043b04c35c4472b169d22fc813808daab&framework=10

Comment 13

[Benjamin Bouvier [:bbouvier] (inactive)]

Thanks for checking! I think Cranelift doesn't run in Godot, though, according to these results. Could we have a raptor-wasm-godot-cranelift-firefox opt that runs with the same about:config prefs as Cranelift for wasm misc, please?

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

It is easy for you to add these options as well based on the patch I have provided in the try run :)

I have done this, here is a try push for you to look at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=044b42c3246129c95baada670bce7112db19890a

Comment 15

[Benjamin Bouvier [:bbouvier] (inactive)]

Great, that looks good to go, thanks!

Comment 16

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1490048 - add cranelift to raptor wasm-misc and wasm-godot tests. r=bbouvier

add cranelift to raptor wasm-misc and wasm-godot tests

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1490048 - add cranelift to raptor wasm-misc and wasm-godot tests. r=bbouvier

add cranelift to raptor wasm-misc and wasm-godot tests.

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4e5dbbdb10f3

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/4e5dbbdb10f31f6cf8460011c46a47dd4d135b7f