1490051 - Cleanup funsize workers.

Status: RESOLVED WONTFIX

(Release Engineering :: Release Automation, enhancement)

Description

[Tom Prince [:tomprince]]

There is unused code to repackage partials (we generate them in the new format directly, now) and pass data to the tasks indirectly through `extra`.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1490051: Remove unused partial recompression support; r?sfraser

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1490051: Pass partial configuration to funsize explicitly, rather than smuggling through the task `extra`s; r?sfraser

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

Comment on attachment 9007833 [details]
Bug 1490051: Remove unused partial recompression support; r?sfraser

Simon Fraser [:sfraser] ⌚️GMT has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34ef3514a7e6
Remove unused partial recompression support; r=sfraser

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/34ef3514a7e6

Comment 6

[Simon Fraser [:sfraser] ⌚️GMT]

We've a discussion going on about how we should pass in task configuration. The current setup is a json blob, about 40 lines / 1900 characters, and is passed in through 'extra'.

The options seem to be:

1. Use `extra` in the task definition
2. Encode a json blob into a string, in an environment variable
3. Ask for a schema change to the worker's payload.

Which of these is preferred? Are there other options we've missed?

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Yeah, I chatted with Tom briefly, and he pointed out that #2 isn't very readable, since it's JSON-in-JSON.  #3 is sort of off the table as far as docker-worker is concerned, but for generic-worker, maybe we could propose that `env` values can be arbitrary objects that are JSON-serialized into OS environment variables?  At any rate, moving to g-w for this is probably not worth it.

Given that "don't use task.extra to send data to the task" is a mild preference, and that readability is important, and that the existing code implements #1, it seems to me like a tie between #1 and #2.  Doing both seems worse than doing either one.

Comment 8

[Simon Fraser [:sfraser] ⌚️GMT]

Thanks! For me, I'd be happy to move away from `extra` if there was an option that kept the readability. I'd vote for #1, as #2 also means we need to modify the release templates used in ship-it

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

#1's good, let's do it (and I think that means "no change", so easily done!)

Comment 10

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/8799ee1dcdff