1490086 - Parenthesis do not match an unmatched closing parenthesis

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

Steps to reproduce:

 * Open up console.
 * Type `10 - 5 / 2`
 * Move text cursor to the left and insert a closing parenthesis after the 5
 * `10 - 5) / 2`
 * Move text cursor to the beginning, and add an opening parenthesis.

Expected behavior:

 * The text to be `(10 - 5) / 2`

Actual behavior:

 * The text is `()10 - 5) / 2`.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

So, this is because of the `autoCloseEnabled` config of codeMirror.
It is driven by the "Autoclose brackets" option in Settings panel (under "Editor Preferences").
We could either: turn it off in the console (Chrome does not seem to have such thing), or fix the underlying issue (not not close if there's a single closing brackets after) on codeMirror.

Not sure what would be the best to do.

The easiest would definitely to not have autoclose in the console. So maybe we can do that for the moment, and then later fix the issue and respect the user choice from the settings ?

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Personally I really don't like auto bracketing behavior, as it breaks my typing habits, so I would be a fan of removing it all together. I know there is much more that goes into that decision though.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Greg Tatum [:gregtatum] from comment #2)
> Personally I really don't like auto bracketing behavior, as it breaks my
> typing habits, so I would be a fan of removing it all together. I know there
> is much more that goes into that decision though.

Yeah, I originally thought we should respect the global option. But given STR like Comment 0, and hitting this inadvertently through normal console use I'd lean more towards forcing it off for the console.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1490086 - Disable autoCloseBrackets feature for console input;r=nchevobbe

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9009266 [details]
Bug 1490086 - Disable autoCloseBrackets feature for console input;r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/416b3f8e0883
Disable autoCloseBrackets feature for console input;r=nchevobbe

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/416b3f8e0883