Closed
Bug 1490102
Opened 6 years ago
Closed 5 years ago
Add a test for bug 1478335 (double-tap zooming out)
Categories
(Core :: Panning and Zooming, enhancement, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla65
People
(Reporter: botond, Assigned: botond)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 obsolete file)
I'd like to write a test for bug 1478335. I have a WIP test in bug 1478335 comment 16, but it's not behaving as expected (as is usual for an APZ mochitest), and I don't want to block landing the fix there on getting the test to work.
Assignee | ||
Comment 1•6 years ago
|
||
I have an updated WIP which is passing [1], but it's passing without the fix too [2], and I need to investigate why. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=695d668341e90b413b3b5e35aff2870c5a813534 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=38f242654a4d16736d026fbca3f96c911771b054
Assignee | ||
Comment 2•6 years ago
|
||
It would significantly speed up the investigation process if I could run these tests on desktop.
Depends on: 1470504
Assignee | ||
Comment 3•6 years ago
|
||
Debugged the test on desktop (which I can now do thanks to bug 1470504, yay!) and got it working properly (that is, failing without the fix for bug 1478335 and passing with it) locally. https://treeherder.mozilla.org/#/jobs?repo=try&revision=4893579e1adeabc00be63be0d83a8b0fd183cf98
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #3) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=4893579e1adeabc00be63be0d83a8b0fd183cf98 Unfortunately, it's not passing on Android. I think the issue is the difference screen size (and aspect ratio) on desktop vs. Android; double-tap-to-zoom behaviour is fairly dependent on the dimensions of elements relative to the screen, making it tricky to get uniform behaviour across desktop and Android.
Assignee | ||
Comment 5•6 years ago
|
||
This required some changes to the page structure to exercise the codepath that bug 1478335 fixed.
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3621d40b3403 Augment helper_basic_doubletap_zoom to also test zooming out. r=kats
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3621d40b3403
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•5 years ago
|
Flags: in-testsuite+
Whiteboard: [gfx-noted] → [gfx-noted][checkin-needed-beta]
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/releases/mozilla-beta/rev/244c37e0926f
Whiteboard: [gfx-noted][checkin-needed-beta] → [gfx-noted]
Comment 9•5 years ago
|
||
Backed out for causing mochitest Android 4.3 API16+ failures on test_group_zoom.html. Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&revision=244c37e0926f5487c130dcc793b4510c4251bc6c&searchStr=Android%2C4.3%2CAPI16%2B&selectedJob=214156339 Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214156339&repo=mozilla-beta&lineNumber=1678 Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/cb7da1cd7bd115c37f05e547b34853e127a88cac [task 2018-11-27T16:51:27.650Z] 16:51:27 INFO - 119 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_zoom.html | helper_basic_doubletap_zoom.html | The initial_resolution is 0.190476194024086, which is some sane value [task 2018-11-27T16:51:27.651Z] 16:51:27 INFO - Buffered messages finished [task 2018-11-27T16:51:27.651Z] 16:51:27 INFO - 120 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_zoom.html | helper_basic_doubletap_zoom.html | The first double-tap has increased the resolution to 0.190476194024086 [task 2018-11-27T16:51:27.652Z] 16:51:27 INFO - spawnTest/w.ok@gfx/layers/apz/test/mochitest/apz_test_utils.js:266:52 [task 2018-11-27T16:51:27.652Z] 16:51:27 INFO - test@gfx/layers/apz/test/mochitest/helper_basic_doubletap_zoom.html:45:3 [task 2018-11-27T16:51:27.653Z] 16:51:27 INFO - driveTest@gfx/layers/apz/test/mochitest/apz_test_utils.js:430:19 [task 2018-11-27T16:51:27.654Z] 16:51:27 INFO - 121 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_zoom.html | helper_basic_doubletap_zoom.html | The second double-tap has decreased the resolution to 0.190476194024086 [task 2018-11-27T16:51:27.654Z] 16:51:27 INFO - spawnTest/w.ok@gfx/layers/apz/test/mochitest/apz_test_utils.js:266:52 [task 2018-11-27T16:51:27.655Z] 16:51:27 INFO - test@gfx/layers/apz/test/mochitest/helper_basic_doubletap_zoom.html:51:3 [task 2018-11-27T16:51:27.655Z] 16:51:27 INFO - driveTest@gfx/layers/apz/test/mochitest/apz_test_utils.js:430:19 [task 2018-11-27T16:51:37.854Z] 16:51:37 INFO - 122 INFO TEST-OK | gfx/layers/apz/test/mochitest/test_group_zoom.html | took 82648ms [task 2018-11-27T16:51:37.855Z] 16:51:37 INFO - 123 INFO TEST-START | gfx/layers/apz/test/mochitest/test_interrupted_reflow.html
Flags: needinfo?(botond)
Assignee | ||
Comment 10•5 years ago
|
||
I didn't request an uplift of this to 64 for a reason :) It depends on test infrastructure added in bug 1496864 which is only on 65. (Sorry, I probably should have set the status flag to be more explicit about it.)
Flags: needinfo?(botond)
Updated•5 years ago
|
Attachment #9023870 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•