1490103 - [wpt-sync] Sync PR 12938 - Honor given outputChannelCount for AudioWorkletNodeOptions

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12938 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12938
Details from upstream follow.

Hongchan Choi <[e-mail]> wrote:
>  Honor given outputChannelCount for AudioWorkletNodeOptions
>  
>  When both input and output are 1 in AudioWorkletNode, it overrides
>  the output channel count dynamically even if it is specified by user.
>  Fix it so the specified channel count can be honored correctly.
>  
>  See also: https://webaudio.github.io/web-audio-api/#configuring-channels-with-audioworkletnodeoptions
>  
>  Bug: 861681
>  Test: webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html
>  Change-Id: Ie5cc7f3a5a2b48c67cdf39e93bde8477bfedae89
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1216072
>  WPT-Export-Revision: f5d44136e2905da6d796bf3aec55d012a22a4800

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=539ea72235ba2b899ce0bda41e2da9921fcab68d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=602b53e4981ca3cc25c1f69b0b6ec27ee2ec2bee

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=521e1a3822ad501a12f363082bf39b78724e0e09

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests
TIMEOUT: 1

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html: TIMEOUT

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9888dffb8c888e2d71964737df6f5111fecadc64

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b4064627703
[wpt PR 12938] - Honor given outputChannelCount for AudioWorkletNodeOptions, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/7714b8da590d
[wpt PR 12938] - Update wpt metadata, a=testonly

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3b4064627703
https://hg.mozilla.org/mozilla-central/rev/7714b8da590d

Comment 8

[Dorel Luca [:dluca]]

Backed out for WPT mass failure at /fullscreen/idlharness.window.html

Backout: https://hg.mozilla.org/mozilla-central/rev/e1a681345945ab8c8b8270afcd2f62bf042226c2

Failure push: 
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=be6801cdeb537afa655bbd67d12ead8dc01c6c38

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3f3f67d1c0bf5359ac39ddddec5999ceb928e7ca

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199470643&repo=mozilla-central&lineNumber=1487

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e117f4290281
[wpt PR 12938] - Honor given outputChannelCount for AudioWorkletNodeOptions, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ca3864013dd
[wpt PR 12938] - Update wpt metadata, a=testonly

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e117f4290281
https://hg.mozilla.org/mozilla-central/rev/3ca3864013dd