1490136 - Move compilation and evaluation API *definitions* to vm/CompilationAndEvaluation.cpp, out of the oversize jsapi.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jeff Walden [:Waldo]]

Bit tricky finding these definitions in jsapi.cpp for the same reason it was tricky to find the definitions in jsapi.h.

No changes to actual algorithms, just various poking to make things compile again mostly.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Move off-thread compilation out of jsapi.cpp as well

I'd like the binast stuff to be in its own header, really -- including the off-thread bit, ideally -- but the plumbing that would underlie it requires the OffThread enum class, so just put the definition in a weird place for now.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 9007919 [details] [diff] [review]
Patch

Review of attachment 9007919 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the rebase churn :/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05345cae46fa
Move compilation and evaluation API *definitions* to vm/CompilationAndEvaluation.cpp, out of the oversize jsapi.cpp.  r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/bac86b3ddb24
Move off-thread compilation out of jsapi.cpp as well.  r=jandem

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1490136)for build bustaged on /js/src/util/CompleteFile.cpp
Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/dec804107aa9e2c78f374d5e4e2829993a8b8cb9
Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=199173649&revision=bac86b3ddb24f837a1e2b8efc9d9ea522ae58ef3
Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=199174495&repo=mozilla-inbound
:Waldo could you please take a look?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/325e98e82644
Move compilation and evaluation API *definitions* to vm/CompilationAndEvaluation.cpp, out of the oversize jsapi.cpp.  r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/2246564838be
Move off-thread compilation out of jsapi.cpp as well.  r=jandem

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/325e98e82644
https://hg.mozilla.org/mozilla-central/rev/2246564838be