Streamline nsISHistoryListener

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(4 attachments)

nsISHistoryListener has some functionality that isn't currently used: the OnIndexChanged and OnLengthChanged methods, and the ability to cancel some operations. I think the methods were added under bug 1310761, but maybe they're not necessary any more?
nsISHistoryListener can cancel several operations, but the functionality is
only ever used for OnHistoryReload(). So this patch removes it for the other
operations.
Attachment #9007973 - Flags: review?(nika)
They're never used.
Attachment #9007974 - Flags: review?(nika)
Attachment #9007975 - Flags: review?(nika)
Summary: Streamling nsISHistoryListener → Streamline nsISHistoryListener
Attachment #9007973 - Flags: review?(nika) → review+
Comment on attachment 9007974 [details] [diff] [review]
Remove On{Length,Index}Changed from nsISHistoryListener

Review of attachment 9007974 [details] [diff] [review]:
-----------------------------------------------------------------

We shouldn't need this anymore. It existed to do history syncing at one point for preloading iirc
Attachment #9007974 - Flags: review?(nika) → review+
Attachment #9007975 - Flags: review?(nika) → review+
frg: this should suffice for comm-central.
Attachment #9008262 - Flags: review?(frgrahl)
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5292dc5332d6
Minimize cancelability in nsISHistoryListener. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e6396a117f
Remove On{Length,Index}Changed from nsISHistoryListener. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/780ffc5018c4
Add a clarifying comment. r=nika
https://hg.mozilla.org/mozilla-central/rev/5292dc5332d6
https://hg.mozilla.org/mozilla-central/rev/a7e6396a117f
https://hg.mozilla.org/mozilla-central/rev/780ffc5018c4
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment on attachment 9008262 [details] [diff] [review]
Update comm-central for nsISHistoryListener changes

Great thanks. If I find some time I will clean out the SeaMonkey sessionstore and align with Firefox. Too much old cruft in it.
Attachment #9008262 - Flags: review?(frgrahl) → review+
frg, what exactly is the status of SeaMonkey right now? Recently I've heard it described as "badly busted" and even "dead". There have been some small XPIDL clean-ups that I wanted to do but I couldn't just because of some code in suite/.
Flags: needinfo?(frgrahl)
> frg, what exactly is the status of SeaMonkey right now?

Answer via email because not directly bug relevant.
Flags: needinfo?(frgrahl)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/4a211a1901dd
Update comm-central for nsISHistoryListener changes. r=frg
You need to log in before you can comment on or make changes to this bug.