1490158 - Streamline nsISHistoryListener

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[Nicholas Nethercote [inactive]]

nsISHistoryListener has some functionality that isn't currently used: the OnIndexChanged and OnLengthChanged methods, and the ability to cancel some operations. I think the methods were added under bug 1310761, but maybe they're not necessary any more?

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Minimize cancelability in nsISHistoryListener

nsISHistoryListener can cancel several operations, but the functionality is
only ever used for OnHistoryReload(). So this patch removes it for the other
operations.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Remove On{Length,Index}Changed from nsISHistoryListener

They're never used.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Add a clarifying comment

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9007974 [details] [diff] [review]
Remove On{Length,Index}Changed from nsISHistoryListener

Review of attachment 9007974 [details] [diff] [review]:
-----------------------------------------------------------------

We shouldn't need this anymore. It existed to do history syncing at one point for preloading iirc

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Update comm-central for nsISHistoryListener changes

frg: this should suffice for comm-central.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5292dc5332d6
Minimize cancelability in nsISHistoryListener. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e6396a117f
Remove On{Length,Index}Changed from nsISHistoryListener. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/780ffc5018c4
Add a clarifying comment. r=nika

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5292dc5332d6
https://hg.mozilla.org/mozilla-central/rev/a7e6396a117f
https://hg.mozilla.org/mozilla-central/rev/780ffc5018c4

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9008262 [details] [diff] [review]
Update comm-central for nsISHistoryListener changes

Great thanks. If I find some time I will clean out the SeaMonkey sessionstore and align with Firefox. Too much old cruft in it.

Comment 9

[Nicholas Nethercote [inactive]]

frg, what exactly is the status of SeaMonkey right now? Recently I've heard it described as "badly busted" and even "dead". There have been some small XPIDL clean-ups that I wanted to do but I couldn't just because of some code in suite/.

Comment 10

[Frank-Rainer Grahl (:frg)]

> frg, what exactly is the status of SeaMonkey right now?

Answer via email because not directly bug relevant.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4a211a1901dd
Update comm-central for nsISHistoryListener changes. r=frg