1490259 - MSVC Perma-failure z:/build/build/src/toolkit/xre/nsAppRunner.cpp(3771): error C2220: warning treated as error - no 'object' file generated

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=198609823&repo=mozilla-central

https://queue.taskcluster.net/v1/task/UAnV7PrWTg-FekAr5pr5LA/runs/0/artifacts/public/logs/live_backing.log

10:49:09     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/vr/openvr'
10:49:09     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/xre'
10:49:09     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x86/cl.exe -FonsAppRunner.obj -c  -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DPROXY_PRINTING=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC '-DMOZ_APP_NAME="firefox"' '-DMOZ_APP_BASENAME="Firefox"' '-DMOZ_APP_DISPLAYNAME="Firefox Nightly"' '-DMOZ_APP_VERSION="64.0a1"' '-DOS_TARGET="WINNT"' '-DMOZ_WIDGET_TOOLKIT="windows"' -DMOZ_UPDATER '-DTARGET_OS_ABI="WINNT_x86-msvc"' -DGRE_MILESTONE=64.0a1 -DAPP_VERSION=64.0a1 '-DAPP_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}' -DMOZ_BUILD_APP_IS_BROWSER -DTOPOBJDIR=z:/build/build/src/obj-firefox -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/toolkit/xre -Iz:/build/build/src/obj-firefox/toolkit/xre -Iz:/build/build/src/toolkit/components/printingui -Iz:/build/build/src/toolkit/components/printingui -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/other-licenses/nsis/Contrib/CityHash/cityhash -Iz:/build/build/src/toolkit/components/find -Iz:/build/build/src/toolkit/components/printingui/ipc -Iz:/build/build/src/toolkit/components/windowwatcher -Iz:/build/build/src/toolkit/profile -Iz:/build/build/src/config -Iz:/build/build/src/dom/base -Iz:/build/build/src/dom/commandhandler -Iz:/build/build/src/dom/ipc -Iz:/build/build/src/dom/webbrowserpersist -Iz:/build/build/src/testing/gtest/mozilla -Iz:/build/build/src/toolkit/crashreporter -Iz:/build/build/src/xpcom/build -Iz:/build/build/src/security/sandbox/chromium -Iz:/build/build/src/security/sandbox/chromium-shim -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX    -Fdgenerated.pdb -FS  z:/build/build/src/toolkit/xre/nsAppRunner.cpp
10:49:09     INFO -  nsAppRunner.cpp
10:49:09     INFO -  z:/build/build/src/toolkit/xre/nsAppRunner.cpp(3771): error C2220: warning treated as error - no 'object' file generated
10:49:09     INFO -  z:/build/build/src/toolkit/xre/nsAppRunner.cpp(3771): warning C4018: '>=': signed/unsigned mismatch
10:49:09     INFO -  z:/build/build/src/config/rules.mk:1110: recipe for target 'nsAppRunner.obj' failed
10:49:09     INFO -  mozmake.EXE[4]: *** [nsAppRunner.obj] Error 2
10:49:09     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/xre'
10:49:09     INFO -  mozmake.EXE[4]: *** Waiting for unfinished jobs....
10:49:09     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/thebes'
10:49:09     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/thebes'
10:49:09     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/thebes'
10:49:09     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/thebes'
10:49:09     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/devtools/shared/heapsnapshot'
10:49:09     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x86/cl.exe -FoFileDescriptorOutputStream.obj -c  -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DGOOGLE_PROTOBUF_NO_RTTI -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/devtools/shared/heapsnapshot -Iz:/build/build/src/obj-firefox/devtools/shared/heapsnapshot -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX    -Fdgenerated.pdb -FS  z:/build/build/src/devtools/shared/heapsnapshot/FileDescriptorOutputStream.cpp
10:49:09     INFO -  FileDescriptorOutputStream.cpp

This started to fail on central after bug 1489297 landed here: https://hg.mozilla.org/mozilla-central/rev/d0e3bb6adff0

Comment 1

[Cosmin Sabou [:CosminS]]

David, could you please take a look at this? Thank you

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Bug 1490259 - Fix signed/unsigned comparison warning.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9008158 [details]
Bug 1490259 - Fix signed/unsigned comparison warning.

Aaron Klotz [:aklotz] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15d6b91eae27
Fix signed/unsigned comparison warning. r=aklotz

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/15d6b91eae27

Comment 6

[Dorel Luca [:dluca]]

Looks like this issue is still present on central, I made bug 1490259 for it.

Comment 7

[Dorel Luca [:dluca]]

I meant bug 1491572

Comment 8

[Intermittent Failures Robot]

9 failures in 2684 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1
* mozilla-central: 8

Platform breakdown:
* windows2012-32: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1490259&startday=2018-09-10&endday=2018-09-16&tree=all

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That's a totally different bug in a different file.