Closed
Bug 1490277
Opened 6 years ago
Closed 6 years ago
In WebAssembly.{Table, Memory} constructors, don't call [[HasProperty]] on the descriptor objects
Categories
(Core :: JavaScript: WebAssembly, enhancement, P3)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: lth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
5.04 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
Per spec: https://heycam.github.io/webidl/#es-to-dictionary Tested in: wasm/jsapi/memory/constructor.any.js wasm/jsapi/table/constructor.any.js (which runs in jstests and wpt).
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Priority: -- → P3
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9009171 -
Flags: review?(jseward)
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9009171 [details] [diff] [review] bug1490277-avoid-hasproperty.patch Review of attachment 9009171 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: testing/web-platform/meta/wasm/jsapi/memory/constructor.any.js.ini @@ +1,1 @@ > [constructor.any.html] Remove the file
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9009171 [details] [diff] [review] bug1490277-avoid-hasproperty.patch Review of attachment 9009171 [details] [diff] [review]: ----------------------------------------------------------------- Looks plausible.
Attachment #9009171 -
Flags: review?(jseward) → review+
|
|
Assignee | |
Comment 4•6 years ago
|
||
Now with changes to our private tests. Carrying jseward's r+.
Attachment #9009171 -
Attachment is obsolete: true
Attachment #9009618 -
Flags: review+
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/df613c034e27 use correct protocol for reading memory/table descriptors. r=jseward
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/df613c034e27
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•