1490277 - In WebAssembly.{Table, Memory} constructors, don't call [[HasProperty]] on the descriptor objects

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Per spec: https://heycam.github.io/webidl/#es-to-dictionary

Tested in:

wasm/jsapi/memory/constructor.any.js
wasm/jsapi/table/constructor.any.js

(which runs in jstests and wpt).

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1490277-avoid-hasproperty.patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 9009171 [details] [diff] [review]
bug1490277-avoid-hasproperty.patch

Review of attachment 9009171 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: testing/web-platform/meta/wasm/jsapi/memory/constructor.any.js.ini
@@ +1,1 @@
>  [constructor.any.html]

Remove the file

Comment 3

[Julian Seward [:jseward]]

Comment on attachment 9009171 [details] [diff] [review]
bug1490277-avoid-hasproperty.patch

Review of attachment 9009171 [details] [diff] [review]:
-----------------------------------------------------------------

Looks plausible.

Comment 4

[Lars T Hansen [:lth]]

Attachment: bug1490277-avoid-hasproperty-v2.patch

Now with changes to our private tests.  Carrying jseward's r+.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df613c034e27
use correct protocol for reading memory/table descriptors.  r=jseward

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df613c034e27