Add/support the DID: protocol handler
Categories
(WebExtensions :: General, defect, P3)
Tracking
(Not tracked)
People
(Reporter: danieljb2, Assigned: ticapix)
References
(Depends on 1 open bug)
Details
(Whiteboard: [design-decision-needed])
Attachments
(1 file)
Updated•7 years ago
|
Updated•7 years ago
|
![]() |
||
Updated•6 years ago
|
Comment 1•3 years ago
|
||
We'd like the extension protocol_handler to remain very close if not the same as RPH. This request is about adding DID to the allow list.
@tantek any thoughts on allowing DID in RPH?
@dragana what is the decision process for adding protocols in RPH?
There are a number of related links for this here:
I think this issue may be the best place for interested parties to start:
Comment 3•3 years ago
|
||
The process for adding schemes to RPH is getting the scheme standardized in the HTML Standard. That hasn't happened here so we can either leave this open until that happens or WONTFIX. Per comments on the standards-positions repository I don't think we're particularly keen to add these kind of schemes.
Comment 4•3 years ago
|
||
Per comments on the standards-positions repository I don't think we're particularly keen to add these kind of schemes.
Maybe we can continue the discussion n the standards-positions issue, to clarify what are the actual concerns. If I've understood it correctly, there are mainly 2 negative positions:
- "sharing a single origin" - https://github.com/mozilla/standards-positions/issues/339#issuecomment-630517916
- "need to review each scheme separately" - https://github.com/mozilla/standards-positions/issues/339#issuecomment-644289267
I believe Fred already replied to the first one, asking about the issue of Firefox already whitelisting ipfs / ipns protocols already for extensions. It'd be useful to understand better why this concern affects more to the HTML API.
Regarding the second issue, about apparently endorsing all the protocols once they are accepted in the safe-list, I may agree with doing an independent review of each of them. However, I wonder also about the fact that they are already considered safe by Firefox for extensions.
Updated•3 years ago
|
Assignee | ||
Comment 5•5 months ago
|
||
Assignee | ||
Comment 6•5 months ago
|
||
Hello,
Here is an example of a simple did:web resolver extension https://gitlab.com/pierre.gronlier/extension-did-web-resolver/ that can be implemented if https://phabricator.services.mozilla.com/D240768 is accepted.
Updated•5 months ago
|
Comment 7•5 months ago
|
||
On the one hand there seems to be a desire for the list of supported protocols to be consistent with the web platform, and the issue tracking did
support in the registerProtocolHandler
method is at bug 1639016.
On the other hand, we have already accepted other non-standard protocols before in the extension-specific protocol_handlers
field in bug 1428446.
Assignee | ||
Comment 8•5 months ago
|
||
Hello,
Chromium seems to have the same dilemma:
the documentation says that only https://html.spec.whatwg.org/multipage/system-state.html#safelisted-scheme are safe
BUT
The code says that all below are valid, which include ipfs
, did
, ...
static constexpr const char* const kProtocolSafelist[] = {
"bitcoin", "cabal", "dat", "did", "doi", "dweb", "ethereum",
"geo", "hyper", "im", "ipfs", "ipns", "irc", "ircs",
"magnet", "mailto", "matrix", "mms", "news", "nntp", "openpgp4fpr",
"sip", "sms", "smsto", "ssb", "ssh", "tel", "urn",
"webcal", "wtai", "xmpp"};
Code history shows that did
is in Chromium safelist since 2020-08-24 12:27
Could Firefox fast-forward 4years 😁?
Comment 9•5 months ago
|
||
(In reply to Pierre Gronlier from comment #8)
Code history shows that
did
is in Chromium safelist since 2020-08-24 12:27
Your code history lookup got to the point where the line was introduced. That is not the same commit where these schemes were added. I found that these schemes got into Chromium with https://source.chromium.org/chromium/chromium/src/+/4e8ed0cecce04c5c55dd84a09e4df0d0f11c660f and the following commit message:
This CL adds "cabal", "dat", "did", "dweb", "ethereum", "hyper",
"ipfs", "ipns", "ssb" to the safelist of
navigator.registerProtocolHandler. Chrome status entry is [1]
and feature has been discussed in [2] [3] [4] [5]. Currently,
the WHATWG and WPT changes are pending on the Mozilla position
review [6].[1] https://www.chromestatus.com/feature/4776602869170176
[2] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/29sFh4tTdcs/K4XroilVBAAJ
[3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7nHTRUP1EGY
[4] https://github.com/whatwg/html/issues/3935
[5] https://github.com/whatwg/html/issues/3998
[6] https://github.com/mozilla/standards-positions/issues/339
Note that the last s-p link is the same as the one linked from bug 1639016.
Assignee | ||
Comment 10•3 months ago
|
||
Fair point @robwu
Would you know what is missing to move forward on the primarily topic of this ticket which is to add did
to the list of accepted scheme handler for extensions ?
Who might be the proper reviewer(s) ?
Best regards
Description
•