1490387 - BigInt bitwise operators

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Robin Templeton [:terpri]]

Implement BigInt support for bitwise operators.

Comment 1

[Robin Templeton [:terpri]]

Attachment: bug 1490387 - Part 1: Add BigInt methods for bitwise operations.

Comment 2

[Robin Templeton [:terpri]]

Attachment: bug 1490387 - Part 2: Implement ToInt32OrBigInt operation.

Comment 3

[Robin Templeton [:terpri]]

Attachment: bug 1490387 - Part 3: Implement BigInt support for bitwise operators.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 9008117 [details]
bug 1490387 - Part 2: Implement ToInt32OrBigInt operation.

Jan de Mooij [:jandem] has approved the revision.

Comment 5

[Jan de Mooij [:jandem]]

Comment on attachment 9008116 [details]
bug 1490387 - Part 1: Add BigInt methods for bitwise operations.

Jan de Mooij [:jandem] has approved the revision.

Comment 6

[Jan de Mooij [:jandem]]

Comment on attachment 9008118 [details]
bug 1490387 - Part 3: Implement BigInt support for bitwise operators.

Jan de Mooij [:jandem] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5433e5f72f23
Part 1: Add BigInt methods for bitwise operations. r=jandem

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05c1ab8569bd
Part 2: Implement ToInt32OrBigInt operation. r=jandem

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65d8d6533300
Part 3: Implement BigInt support for bitwise operators. r=jandem

Comment 10

[Arthur Iakab [arthur_iakab]]

Backed out changeset 5433e5f72f23 (bug 1490387)for causing spidermokey build bustages CLOSED TREE Part1 
Backed out changeset 05c1ab8569bd (bug 1490387)for causing spidermokey build bustages CLOSED TREE Part2 
Backed out changeset 65d8d6533300 (bug 1490387)for causing spidermokey build bustages CLOSED TREE Part3 
Backout push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=3519c8034245436f261446d4f2820436b5205f1e
Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=65d8d65333008acdf5ab79df0e495168ceb19a43
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199546467&repo=autoland

:terpri The bustages occurred in part 3 but not sure if the bustages are present in the other patches because I have cancelled the jobs from part 1 and part 2. Please check all the patches.

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/819c87ba38b7
Backed out changeset 5433e5f72f23 for causing spidermokey build bustages CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/de10f7dce98f
Backed out changeset 05c1ab8569bd for causing spidermokey build bustages CLOSED TREE

Comment 12

[Robin Templeton [:terpri]]

I think the main issue is that JIT instructions for bitwise operators now need to return JS values in some situations, but are expected to always return ints. I'll try changing the return type of the unspecialized ops and see if it fixes the JIT test failures.

Comment 13

[Robin Templeton [:terpri]]

The new revision (with Ion type errors fixed) passes all of the JS tests, so it should be ready to land now. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d4986b5a5c120b1b88361a7d1a0ef62339c2ee5&selectedJob=199831952

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e69d3f0b8967
Part 1: Add BigInt methods for bitwise operations. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b74cf577c401
Part 2: Implement ToInt32OrBigInt operation. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d5c22661c860
Part 3: Implement BigInt support for bitwise operators. r=jandem

Comment 15

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e69d3f0b8967
https://hg.mozilla.org/mozilla-central/rev/b74cf577c401
https://hg.mozilla.org/mozilla-central/rev/d5c22661c860