1490407 - Cannot reland backouted patches series

Status: RESOLVED DUPLICATE of bug 1489126

(Conduit :: Lando, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I'd like to reland patch series D5474 [1], and had reopened the revision and all the revisions it depends on. But the button is "Landing Blocked". 

D5474 [2] is ok to be relanded though.

[1] https://lando.services.mozilla.com/D5474/
[2] https://lando.services.mozilla.com/revisions/D5474/14287/

Comment 1

[Tom Prince [:tomprince]]

This is partly a duplicate of Bug 1489126, but it also appears that lando, in that the parent revisions are blocked because of missing author information. But I'm only seeing single revision on the stacked landing page, when I would expect to see all 4 revisions in that stack.

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #0)
> D5474 [2] is ok to be relanded though.

This is incorrect, clicking "Re-Land D5474: Preview Landing" would show you:
> Landing Blockers:
>  - This diff does not have the proper author information uploaded to Phabricator. This can happen if the diff was created using the web UI, or a non standard client. The author should re-upload the diff to Phabricator using the "arc diff" command. 
> - This revision depends on the following revision which is still open: D5472 


(In reply to Tom Prince [:tomprince] from comment #1)
> This is partly a duplicate of Bug 1489126, but it also appears that lando,
> in that the parent revisions are blocked because of missing author
> information. But I'm only seeing single revision on the stacked landing
> page, when I would expect to see all 4 revisions in that stack.

To avoid needing to special case this, or have code which can display an arbitrary DAG of parents, if a revision is not landable we only show it and the blocker. The next iteration of this UI coming in Bug 1490337 will always display the full graph.